diff options
| author | Rémy Coutable <remy@rymai.me> | 2016-11-18 12:02:45 +0100 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2016-11-18 12:02:45 +0100 |
| commit | 2fb862ccc6687273ada997743392d9dab7b31d08 (patch) | |
| tree | 5d67a4542bdc088ae80c5011e5979a2952fe46ba | |
| parent | ec3b1c6d6e6aac5791625efcefba09e1b3644e96 (diff) | |
| download | gitlab-ce-24599-spec-lib-gitlab-backend-shell_spec-rb-causes-other-specs-to-fail.tar.gz | |
Rely on Gitlab::Shell public API, not reading internal files it may use24599-spec-lib-gitlab-backend-shell_spec-rb-causes-other-specs-to-fail
It ensures we rely on `Gitlab::Shell`'s public API and not on its
internal. Since `Gitlab::Shell` is caching the value of its token, the
only way to get the correct token is to call
`Gitlab::Shell.secret_token`, not to read the
`Gitlab.config.gitlab_shell.secret_file` file!
Signed-off-by: Rémy Coutable <remy@rymai.me>
| -rw-r--r-- | spec/requests/api/internal_spec.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/requests/api/internal_spec.rb b/spec/requests/api/internal_spec.rb index 8f1a1f9e827..03796f20e36 100644 --- a/spec/requests/api/internal_spec.rb +++ b/spec/requests/api/internal_spec.rb @@ -5,7 +5,7 @@ describe API::API, api: true do let(:user) { create(:user) } let(:key) { create(:key, user: user) } let(:project) { create(:project) } - let(:secret_token) { File.read Gitlab.config.gitlab_shell.secret_file } + let(:secret_token) { Gitlab::Shell.secret_token } describe "GET /internal/check", no_db: true do it do |