summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKushal Pandya <kushal@gitlab.com>2017-02-07 11:34:42 +0530
committerKushal Pandya <kushal@gitlab.com>2017-02-07 11:34:42 +0530
commit00a23ef7ed26c03bfa0e99f502a7b5324700774e (patch)
treebb8e75b934bc0c36de01451f4047dc626990e32f
parent44ac376f6611eb51ac31252bd6baf92d544501cb (diff)
downloadgitlab-ce-24716-fix-ctrl-click-links.tar.gz
Update param name, add test for `e.which = 2`24716-fix-ctrl-click-links
-rw-r--r--spec/javascripts/merge_request_tabs_spec.js21
1 files changed, 19 insertions, 2 deletions
diff --git a/spec/javascripts/merge_request_tabs_spec.js b/spec/javascripts/merge_request_tabs_spec.js
index 1a0fcd4e33e..07f9797c229 100644
--- a/spec/javascripts/merge_request_tabs_spec.js
+++ b/spec/javascripts/merge_request_tabs_spec.js
@@ -84,9 +84,9 @@ require('vendor/jquery.scrollTo');
const tabUrl = $(commitsLink).attr('href');
spyOn($.fn, 'attr').and.returnValue(tabUrl);
- spyOn(window, 'open').and.callFake(function (url, name) {
+ spyOn(window, 'open').and.callFake(function (url, target) {
expect(url).toEqual(tabUrl);
- expect(name).toEqual('_blank');
+ expect(target).toEqual('_blank');
});
this.class.clickTab({
@@ -96,6 +96,23 @@ require('vendor/jquery.scrollTo');
stopImmediatePropagation: function () {}
});
});
+ it('opens page tab in a new browser tab with Middle-click - Mac/PC', function () {
+ const commitsLink = '.commits-tab li a';
+ const tabUrl = $(commitsLink).attr('href');
+
+ spyOn($.fn, 'attr').and.returnValue(tabUrl);
+ spyOn(window, 'open').and.callFake(function (url, target) {
+ expect(url).toEqual(tabUrl);
+ expect(target).toEqual('_blank');
+ });
+
+ this.class.clickTab({
+ metaKey: false,
+ ctrlKey: false,
+ which: 2,
+ stopImmediatePropagation: function () {}
+ });
+ });
});
describe('#setCurrentAction', function () {