diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2017-01-06 08:36:54 +0000 |
|---|---|---|
| committer | Filipa Lacerda <filipa@gitlab.com> | 2017-01-06 19:36:55 +0000 |
| commit | 1d5a8a55394e0729f84d18c48a4198e001f77c7b (patch) | |
| tree | fc467e3f05d725fa28c5bed0cbba214867bcaf49 | |
| parent | f77f736ba40c6ba967531592ec48dd3e2cec1ebc (diff) | |
| download | gitlab-ce-26238-buttons-not-accessible.tar.gz | |
Fix html in order to make items accessible through keyboard navigation26238-buttons-not-accessible
Adds CHANGELOG entry
Adds MR ID to CHANGELOG entry
| -rw-r--r-- | app/views/groups/new.html.haml | 2 | ||||
| -rw-r--r-- | app/views/shared/_choose_group_avatar_button.html.haml | 2 | ||||
| -rw-r--r-- | changelogs/unreleased/26238-buttons-not-accessible.yml | 4 |
3 files changed, 6 insertions, 2 deletions
diff --git a/app/views/groups/new.html.haml b/app/views/groups/new.html.haml index d19eaa6add9..38d63fd9acc 100644 --- a/app/views/groups/new.html.haml +++ b/app/views/groups/new.html.haml @@ -21,5 +21,5 @@ = render 'shared/group_tips' .form-actions - = f.submit 'Create group', class: "btn btn-create", tabindex: 3 + = f.submit 'Create group', class: "btn btn-create" = link_to 'Cancel', dashboard_groups_path, class: 'btn btn-cancel' diff --git a/app/views/shared/_choose_group_avatar_button.html.haml b/app/views/shared/_choose_group_avatar_button.html.haml index 000532b1c9a..ee043910548 100644 --- a/app/views/shared/_choose_group_avatar_button.html.haml +++ b/app/views/shared/_choose_group_avatar_button.html.haml @@ -1,4 +1,4 @@ -%a.choose-btn.btn.btn-sm.js-choose-group-avatar-button +%button.choose-btn.btn.btn-sm.js-choose-group-avatar-button %i.fa.fa-paperclip %span Choose File ... diff --git a/changelogs/unreleased/26238-buttons-not-accessible.yml b/changelogs/unreleased/26238-buttons-not-accessible.yml new file mode 100644 index 00000000000..34d38d45709 --- /dev/null +++ b/changelogs/unreleased/26238-buttons-not-accessible.yml @@ -0,0 +1,4 @@ +--- +title: Fixes buttons not being accessible via the keyboard when creating new group +merge_request: 8469 +author: |