diff options
| author | Simon Knox <psimyn@gmail.com> | 2017-02-19 21:40:39 +1100 |
|---|---|---|
| committer | Simon Knox <psimyn@gmail.com> | 2017-02-19 21:40:39 +1100 |
| commit | 229f806835bf63f2f68af8740b54399598ae45bc (patch) | |
| tree | e62e74823c1bef690561ab7fe3700634570f094c | |
| parent | 5cc9ebbe14ce35de1ec45fc7abce3aa9f408ddf2 (diff) | |
| download | gitlab-ce-28295-mr-loading-icon.tar.gz | |
loading icon sometimes toggled alongside MR pipeline contents28295-mr-loading-icon
unbind existing listenerss and remove duplicate MiniPipelineGraph init
| -rw-r--r-- | app/assets/javascripts/merge_request_widget.js.es6 | 1 | ||||
| -rw-r--r-- | app/assets/javascripts/mini_pipeline_graph_dropdown.js.es6 | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/app/assets/javascripts/merge_request_widget.js.es6 b/app/assets/javascripts/merge_request_widget.js.es6 index 4ab33420e59..88f08bbaa34 100644 --- a/app/assets/javascripts/merge_request_widget.js.es6 +++ b/app/assets/javascripts/merge_request_widget.js.es6 @@ -252,7 +252,6 @@ require('./smart_interval'); $('.ci_widget.ci-error').show(); this.setMergeButtonClass('btn-danger'); } - this.initMiniPipelineGraph(); }; MergeRequestWidget.prototype.showCICoverage = function(coverage) { diff --git a/app/assets/javascripts/mini_pipeline_graph_dropdown.js.es6 b/app/assets/javascripts/mini_pipeline_graph_dropdown.js.es6 index 919fcd0a07b..2145e531331 100644 --- a/app/assets/javascripts/mini_pipeline_graph_dropdown.js.es6 +++ b/app/assets/javascripts/mini_pipeline_graph_dropdown.js.es6 @@ -28,7 +28,7 @@ * All dropdown events are fired at the .dropdown-menu's parent element. */ bindEvents() { - $(document).on('shown.bs.dropdown', this.container, this.getBuildsList); + $(document).off('shown.bs.dropdown', this.container).on('shown.bs.dropdown', this.container, this.getBuildsList); } /** |