diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2017-05-12 10:40:45 +0100 |
|---|---|---|
| committer | Filipa Lacerda <filipa@gitlab.com> | 2017-05-12 10:40:45 +0100 |
| commit | b3a2bfc3f590799c2b324505b29b36ec0f91ce1e (patch) | |
| tree | 2411a379136560faefadb208cd7ff51b9264be19 | |
| parent | 75c8fcd372c04953464b45da6eb7f1f9442a3b1d (diff) | |
| download | gitlab-ce-30286-ci-badge-component.tar.gz | |
Fixes after review30286-ci-badge-component
| -rw-r--r-- | app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.js | 5 | ||||
| -rw-r--r-- | app/assets/javascripts/vue_shared/components/ci_badge_link.vue | 2 |
2 files changed, 2 insertions, 5 deletions
diff --git a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.js b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.js index 30ecbcb8a30..d8c27013cd3 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.js +++ b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline.js @@ -26,9 +26,6 @@ export default { status() { return this.mr.pipeline.details.status || {}; }, - statusPath() { - return this.status ? this.status.details_path : ''; - }, }, template: ` <div class="mr-widget-heading"> @@ -47,7 +44,7 @@ export default { <div> <a class="icon-link" - :href="statusPath"> + :href="this.status.details_path"> <ci-icon :status="status" /> </a> </div> diff --git a/app/assets/javascripts/vue_shared/components/ci_badge_link.vue b/app/assets/javascripts/vue_shared/components/ci_badge_link.vue index b0c86273f31..caa28bff6db 100644 --- a/app/assets/javascripts/vue_shared/components/ci_badge_link.vue +++ b/app/assets/javascripts/vue_shared/components/ci_badge_link.vue @@ -13,7 +13,7 @@ import ciIcon from './ci_icon.vue'; * text:"running" // text rendered * } * - * Shared between: + * Used in: * - Pipelines table - first column * - Jobs table - first column * - Pipeline show view - header |