Fix MR tabs and sticky tabs unit specs34153-merge-requests-tabs-should-extend-the-full-width-when-they-become-fixed

2 files changed, 22 insertions, 7 deletions

diff --git a/spec/javascripts/merge_request_tabs_units_spec.js b/spec/javascripts/merge_request_tabs_units_spec.js
index 26a16486195..f412127f939 100644
--- a/spec/javascripts/merge_request_tabs_units_spec.js
+++ b/spec/javascripts/merge_request_tabs_units_spec.js
@@ -1,23 +1,34 @@
 import '~/merge_request_tabs';
 import StickyTabs from '~/sticky_tabs';
 
-describe('MergeRequestTabs', () => {
+describe('MergeRequestTabs units', () => {
   const stickyTabs = {};
   const unstickyTabs = {};
   const options = {
     stickyTabs,
     unstickyTabs,
   };
+  let mergeRequestTabs;
+
+  beforeEach(() => {
+    options.unstickyTabs.getBoundingClientRect = jasmine.createSpy('getBoundingClientRect').and.returnValue({ top: 0 });
+    options.stickyTabs.classList = jasmine.createSpyObj('classList', ['add', 'remove']);
+    options.unstickyTabs.classList = jasmine.createSpyObj('classList', ['add', 'remove']);
+  });
+
+  afterEach(() => {
+    mergeRequestTabs.unbindEvents();
+  });
 
   describe('class constructor', () => {
     it('instantiates StickyTabs if tabs are provided', () => {
-      const mergeRequestTabs = new gl.MergeRequestTabs(options);
+      mergeRequestTabs = new gl.MergeRequestTabs(options);
 
       expect(mergeRequestTabs.stickyTabs).toEqual(jasmine.any(StickyTabs));
     });
 
     it('does not instantiate StickyTabs if no tabs are provided', () => {
-      const mergeRequestTabs = new gl.MergeRequestTabs();
+      mergeRequestTabs = new gl.MergeRequestTabs();
 
       expect(mergeRequestTabs.stickyTabs).toBeUndefined();
     });
@@ -29,14 +40,14 @@ describe('MergeRequestTabs', () => {
     });
 
     it('calls stickyTabs.bindEvents if stickyTabs is set', () => {
-      const mergeRequestTabs = new gl.MergeRequestTabs(options);
+      mergeRequestTabs = new gl.MergeRequestTabs(options);
       mergeRequestTabs.bindEvents();
 
       expect(StickyTabs.prototype.bindEvents).toHaveBeenCalled();
     });
 
     it('does not call stickyTabs.bindEvents if stickyTabs is not set', () => {
-      const mergeRequestTabs = new gl.MergeRequestTabs();
+      mergeRequestTabs = new gl.MergeRequestTabs();
       mergeRequestTabs.bindEvents();
 
       expect(StickyTabs.prototype.bindEvents).not.toHaveBeenCalled();
@@ -49,14 +60,14 @@ describe('MergeRequestTabs', () => {
     });
 
     it('calls stickyTabs.unbindEvents if stickyTabs is set', () => {
-      const mergeRequestTabs = new gl.MergeRequestTabs(options);
+      mergeRequestTabs = new gl.MergeRequestTabs(options);
       mergeRequestTabs.unbindEvents();
 
       expect(StickyTabs.prototype.unbindEvents).toHaveBeenCalled();
     });
 
     it('does not call stickyTabs.unbindEvents if stickyTabs is not set', () => {
-      const mergeRequestTabs = new gl.MergeRequestTabs();
+      mergeRequestTabs = new gl.MergeRequestTabs();
       mergeRequestTabs.unbindEvents();
 
       expect(StickyTabs.prototype.unbindEvents).not.toHaveBeenCalled();
diff --git a/spec/javascripts/sticky_tabs_spec.js b/spec/javascripts/sticky_tabs_spec.js
index d8277e00259..c6e5b38ff95 100644
--- a/spec/javascripts/sticky_tabs_spec.js
+++ b/spec/javascripts/sticky_tabs_spec.js
@@ -9,6 +9,10 @@ describe('StickyTabs', () => {
     stickyTabs = new StickyTabs(stickyTabsEl, unstickyTabsEl);
   });
 
+  afterEach(() => {
+    stickyTabs.unbindEvents();
+  });
+
   describe('class constructor', () => {
     it('sets stickyTabs, unstickyTabs, unstickyTabsHeight and eventListeners', () => {
       expect(stickyTabs.stickyTabs).toBe(stickyTabsEl);