summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Peressini <cperessini@gitlab.com>2017-09-06 13:36:51 +0000
committerChris Peressini <cperessini@gitlab.com>2017-09-07 12:27:39 +0000
commite3c76e6b1bff3599ea79644073620e905e0059d1 (patch)
tree6ff68c462ea3397c7424b5bc814ad0e7f5559053
parent5d2b7aa200e0ce5a66672259d468be4ccc5f9124 (diff)
downloadgitlab-ce-37513-projects-dropdown-copy-tweaks.tar.gz
Change strings for projects dropdown placeholder and error state37513-projects-dropdown-copy-tweaks
gitlab-ce#37513
-rw-r--r--app/assets/javascripts/projects_dropdown/components/projects_list_search.vue2
-rw-r--r--app/assets/javascripts/projects_dropdown/components/search.vue2
-rw-r--r--locale/gitlab.pot18
-rw-r--r--spec/javascripts/projects_dropdown/components/projects_list_search_spec.js2
-rw-r--r--spec/javascripts/projects_dropdown/components/search_spec.js2
5 files changed, 22 insertions, 4 deletions
diff --git a/app/assets/javascripts/projects_dropdown/components/projects_list_search.vue b/app/assets/javascripts/projects_dropdown/components/projects_list_search.vue
index fa5efef2919..8d0c29177e6 100644
--- a/app/assets/javascripts/projects_dropdown/components/projects_list_search.vue
+++ b/app/assets/javascripts/projects_dropdown/components/projects_list_search.vue
@@ -27,7 +27,7 @@ export default {
listEmptyMessage() {
return this.searchFailed ?
s__('ProjectsDropdown|Something went wrong on our end.') :
- s__('ProjectsDropdown|No projects matched your query');
+ s__('ProjectsDropdown|Sorry, no projects matched your search');
},
},
};
diff --git a/app/assets/javascripts/projects_dropdown/components/search.vue b/app/assets/javascripts/projects_dropdown/components/search.vue
index b71997234e5..53bc76d0f2d 100644
--- a/app/assets/javascripts/projects_dropdown/components/search.vue
+++ b/app/assets/javascripts/projects_dropdown/components/search.vue
@@ -53,7 +53,7 @@ export default {
class="form-control"
ref="search"
v-model="searchQuery"
- :placeholder="s__('ProjectsDropdown|Search projects')"
+ :placeholder="s__('ProjectsDropdown|Search your projects')"
/>
<i
v-if="!searchQuery"
diff --git a/locale/gitlab.pot b/locale/gitlab.pot
index e5cf2aeb513..bd3d5b7c839 100644
--- a/locale/gitlab.pot
+++ b/locale/gitlab.pot
@@ -987,6 +987,24 @@ msgstr ""
msgid "Push Rules"
msgstr ""
+msgid "ProjectsDropdown|Loading projects"
+msgstr ""
+
+msgid "ProjectsDropdown|Sorry, no projects matched your search"
+msgstr ""
+
+msgid "ProjectsDropdown|Projects you visit often will appear here"
+msgstr ""
+
+msgid "ProjectsDropdown|Search your projects"
+msgstr ""
+
+msgid "ProjectsDropdown|Something went wrong on our end"
+msgstr ""
+
+msgid "ProjectsDropdown|This feature requires browser localStorage support"
+msgstr ""
+
msgid "Push events"
msgstr ""
diff --git a/spec/javascripts/projects_dropdown/components/projects_list_search_spec.js b/spec/javascripts/projects_dropdown/components/projects_list_search_spec.js
index 59fc2dedba5..67f8a8946c2 100644
--- a/spec/javascripts/projects_dropdown/components/projects_list_search_spec.js
+++ b/spec/javascripts/projects_dropdown/components/projects_list_search_spec.js
@@ -43,7 +43,7 @@ describe('ProjectsListSearchComponent', () => {
expect(vm.listEmptyMessage).toBe('Something went wrong on our end.');
vm.searchFailed = false;
- expect(vm.listEmptyMessage).toBe('No projects matched your query');
+ expect(vm.listEmptyMessage).toBe('Sorry, no projects matched your search');
});
});
});
diff --git a/spec/javascripts/projects_dropdown/components/search_spec.js b/spec/javascripts/projects_dropdown/components/search_spec.js
index f2a23e33325..24d8a00b254 100644
--- a/spec/javascripts/projects_dropdown/components/search_spec.js
+++ b/spec/javascripts/projects_dropdown/components/search_spec.js
@@ -94,7 +94,7 @@ describe('SearchComponent', () => {
expect(vm.$el.classList.contains('search-input-container')).toBeTruthy();
expect(vm.$el.classList.contains('hidden-xs')).toBeTruthy();
expect(inputEl).not.toBe(null);
- expect(inputEl.getAttribute('placeholder')).toBe('Search projects');
+ expect(inputEl.getAttribute('placeholder')).toBe('Search your projects');
expect(vm.$el.querySelector('.search-icon')).toBeDefined();
});
});