summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2017-11-14 11:25:04 +0000
committerFilipa Lacerda <filipa@gitlab.com>2017-11-14 11:25:04 +0000
commit28a67212a07fba973eaf06057f80ce49ba9ef047 (patch)
treebeacdc3e31fea84db01b7d0d6db1a188eb599057
parente5e70f594ed7ffe4edfa6cbc618d58e0313de74d (diff)
downloadgitlab-ce-38869-project-1.tar.gz
Enable eslint38869-project-1
-rw-r--r--app/assets/javascripts/project_new.js32
1 files changed, 14 insertions, 18 deletions
diff --git a/app/assets/javascripts/project_new.js b/app/assets/javascripts/project_new.js
index f8fc9c401d6..ca548d011b6 100644
--- a/app/assets/javascripts/project_new.js
+++ b/app/assets/javascripts/project_new.js
@@ -1,4 +1,4 @@
-/* eslint-disable func-names, space-before-function-paren, no-var, prefer-rest-params, wrap-iife, no-unused-vars, one-var, no-underscore-dangle, prefer-template, no-else-return, prefer-arrow-callback, max-len */
+/* eslint-disable func-names, no-var, no-underscore-dangle, prefer-template, prefer-arrow-callback*/
import VisibilitySelect from './visibility_select';
@@ -14,12 +14,10 @@ export default class ProjectNew {
this.$repoSelects = this.$selects.filter('.js-repo-select');
this.$projectSelects = this.$selects.not('.js-repo-select');
- $('.project-edit-container').on('ajax:before', (function(_this) {
- return function() {
- $('.project-edit-container').hide();
- return $('.save-project-loader').show();
- };
- })(this));
+ $('.project-edit-container').on('ajax:before', () => {
+ $('.project-edit-container').hide();
+ return $('.save-project-loader').show();
+ });
this.initVisibilitySelect();
@@ -71,33 +69,30 @@ export default class ProjectNew {
});
}
- oggleSettings() {
- var self = this;
-
+ toggleSettings() {
this.$selects.each(function () {
var $select = $(this);
var className = $select.data('field')
.replace(/_/g, '-')
.replace('access-level', 'feature');
- self._showOrHide($select, '.' + className);
+ ProjectNew._showOrHide($select, '.' + className);
});
}
toggleSettingsOnclick() {
this.$selects.on('change', this.toggleSettings);
}
- // eslint-disable-next-line class-methods-use-this
- _showOrHide(checkElement, container) {
- var $container = $(container);
+
+ static _showOrHide(checkElement, container) {
+ const $container = $(container);
if ($(checkElement).val() !== '0') {
return $container.show();
- } else {
- return $container.hide();
}
+ return $container.hide();
}
- toggleRepoVisibility () {
+ toggleRepoVisibility() {
var $repoAccessLevel = $('.js-repo-access-level select');
var $lfsEnabledOption = $('.js-lfs-enabled select');
var containerRegistry = document.querySelectorAll('.js-container-registry')[0];
@@ -108,7 +103,8 @@ export default class ProjectNew {
.nextAll()
.hide();
- $repoAccessLevel.off('change')
+ $repoAccessLevel
+ .off('change')
.on('change', function () {
var selectedVal = parseInt($repoAccessLevel.val(), 10);