summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Eastwood <contact@ericeastwood.com>2018-01-04 16:15:09 -0600
committerEric Eastwood <contact@ericeastwood.com>2018-01-04 17:51:52 -0600
commitf4c2eeb2a6885821f8b72f46deb49a55a062bd8c (patch)
treeda9a437d1ce42aaea935f33deefbd078f752ad25
parent545489a59d477172b90390394979baec92fb0e6c (diff)
downloadgitlab-ce-41563-fix-branch-creation-from-issue-in-firefox.tar.gz
Fix custom name in branch creation for issue in Firefox41563-fix-branch-creation-from-issue-in-firefox
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/41563 `event.srcElement` is non-standard, https://developer.mozilla.org/en-US/docs/Web/API/Event/srcElement
-rw-r--r--app/assets/javascripts/create_merge_request_dropdown.js8
1 files changed, 4 insertions, 4 deletions
diff --git a/app/assets/javascripts/create_merge_request_dropdown.js b/app/assets/javascripts/create_merge_request_dropdown.js
index 23425672b16..eedbd3feeb5 100644
--- a/app/assets/javascripts/create_merge_request_dropdown.js
+++ b/app/assets/javascripts/create_merge_request_dropdown.js
@@ -276,13 +276,13 @@ export default class CreateMergeRequestDropdown {
let target;
let value;
- if (event.srcElement === this.branchInput) {
+ if (event.target === this.branchInput) {
target = 'branch';
value = this.branchInput.value;
- } else if (event.srcElement === this.refInput) {
+ } else if (event.target === this.refInput) {
target = 'ref';
- value = event.srcElement.value.slice(0, event.srcElement.selectionStart) +
- event.srcElement.value.slice(event.srcElement.selectionEnd);
+ value = event.target.value.slice(0, event.target.selectionStart) +
+ event.target.value.slice(event.target.selectionEnd);
} else {
return false;
}