summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacopo <beschi.jacopo@gmail.com>2019-02-08 14:02:14 +0100
committerJacopo <beschi.jacopo@gmail.com>2019-02-12 12:45:48 +0100
commitb9087864d03378e9bdc8c802c05bd63486f024ef (patch)
tree87f87735558782e46a8b92272c560329b0a29e18
parentf6e866f0c77b3fea537f5ec08007a634e8bb431d (diff)
downloadgitlab-ce-42086-project-fetch-statistics-api-http-only.tar.gz
Renames permission name for consistency42086-project-fetch-statistics-api-http-only
-rw-r--r--app/workers/project_daily_statistics_worker.rb4
-rw-r--r--config/sidekiq_queues.yml2
-rw-r--r--doc/api/project_traffic.md2
-rw-r--r--doc/user/permissions.md2
4 files changed, 4 insertions, 6 deletions
diff --git a/app/workers/project_daily_statistics_worker.rb b/app/workers/project_daily_statistics_worker.rb
index 96d262ddd22..0aaa3dfd182 100644
--- a/app/workers/project_daily_statistics_worker.rb
+++ b/app/workers/project_daily_statistics_worker.rb
@@ -3,13 +3,11 @@
class ProjectDailyStatisticsWorker
include ApplicationWorker
- # rubocop: disable CodeReuse/ActiveRecord
def perform(project_id)
- project = Project.find_by(id: project_id)
+ project = Project.find_by_id(project_id)
return unless project && project.repository.exists?
Projects::FetchStatisticsIncrementService.new(project).execute
end
- # rubocop: enable CodeReuse/ActiveRecord
end
diff --git a/config/sidekiq_queues.yml b/config/sidekiq_queues.yml
index e475aec2cb5..43939cc914d 100644
--- a/config/sidekiq_queues.yml
+++ b/config/sidekiq_queues.yml
@@ -85,5 +85,5 @@
- [repository_cleanup, 1]
- [delete_stored_files, 1]
- [remote_mirror_notification, 2]
- - [import_issues_csv, 2]
- [project_daily_statistics, 1]
+ - [import_issues_csv, 2]
diff --git a/doc/api/project_traffic.md b/doc/api/project_traffic.md
index 53ef13ba466..00e9a01abec 100644
--- a/doc/api/project_traffic.md
+++ b/doc/api/project_traffic.md
@@ -4,7 +4,7 @@ Every API call to [project](../user/project/index.md) traffics must be authentic
## Get the HTTP fetches of the last 30 days
-Retrieving the fetches statistics requires write access to the repository.
+Retrieving the fetch statistics requires write access to the repository.
Fetches statistics includes both clones and pulls count.
diff --git a/doc/user/permissions.md b/doc/user/permissions.md
index 3fba9c7b71c..e319dc1d234 100644
--- a/doc/user/permissions.md
+++ b/doc/user/permissions.md
@@ -109,7 +109,7 @@ The following table depicts the various user permission levels in a project.
| Force push to protected branches [^4] | | | | | |
| Remove protected branches [^4] | | | | | |
| View project Audit Events | | | | ✓ | ✓ |
-| View project fetch statistics | | | ✓ | ✓ | ✓ |
+| View project traffic | | | ✓ | ✓ | ✓ |
## Project features permissions