summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDylan Griffith <dyl.griffith@gmail.com>2018-02-21 15:34:38 +1100
committerDylan Griffith <dyl.griffith@gmail.com>2018-02-22 10:51:17 +1100
commitaa1b7f2dc4c8995e20deba0e0e9ed60cf04fb1f7 (patch)
tree392156038ab09f18fec2bbf17c7639b5d2699b0c
parent11bf575fe64e55cc932c5629e2d8d103109e0b2b (diff)
downloadgitlab-ce-43134-reduce-queries-pipelines-controller-show.tar.gz
Add inverse_of pipeline -> statuses -> pipeline (#43134)43134-reduce-queries-pipelines-controller-show
-rw-r--r--app/models/ci/pipeline.rb2
-rw-r--r--changelogs/unreleased/43134-reduce-queries-pipelines-controller-show.yml5
2 files changed, 6 insertions, 1 deletions
diff --git a/app/models/ci/pipeline.rb b/app/models/ci/pipeline.rb
index 2abe90dd181..a72a815bfe8 100644
--- a/app/models/ci/pipeline.rb
+++ b/app/models/ci/pipeline.rb
@@ -13,7 +13,7 @@ module Ci
belongs_to :pipeline_schedule, class_name: 'Ci::PipelineSchedule'
has_many :stages
- has_many :statuses, class_name: 'CommitStatus', foreign_key: :commit_id
+ has_many :statuses, class_name: 'CommitStatus', foreign_key: :commit_id, inverse_of: :pipeline
has_many :builds, foreign_key: :commit_id
has_many :trigger_requests, dependent: :destroy, foreign_key: :commit_id # rubocop:disable Cop/ActiveRecordDependent
has_many :variables, class_name: 'Ci::PipelineVariable'
diff --git a/changelogs/unreleased/43134-reduce-queries-pipelines-controller-show.yml b/changelogs/unreleased/43134-reduce-queries-pipelines-controller-show.yml
new file mode 100644
index 00000000000..c1e9614b676
--- /dev/null
+++ b/changelogs/unreleased/43134-reduce-queries-pipelines-controller-show.yml
@@ -0,0 +1,5 @@
+---
+title: Improve performance of pipeline page by reducing DB queries
+merge_request: 17168
+author:
+type: performance