Simplify filtering of non-human users (like ghosts).43304-simplify-filtering-non-human-users

Note that `ghost IS NOT TRUE` is equivalent to `ghost = 'f' OR ghost is
null`:

(true), (false), (NULL)) AS t (flag);
 flag | ?column? | ?column?
------+----------+----------
 t    | f        | f
 f    | t        | t
      | t        | t
(3 rows)

This makes it a little easier to create partial indexes for this (as only
one condition is needed).

Closes #43304.

1 files changed, 1 insertions, 1 deletions

diff --git a/app/models/user.rb b/app/models/user.rb
index f5eeba27572..0401a244566 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -431,7 +431,7 @@ class User < ActiveRecord::Base
   end
 
   def self.non_internal
-    where(Hash[internal_attributes.zip([[false, nil]] * internal_attributes.size)])
+    where(internal_attributes.map { |attr| "#{attr} IS NOT TRUE" }.join(" AND "))
   end
 
   #