summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Greiling <mike@pixelcog.com>2018-03-12 18:00:44 -0500
committerMike Greiling <mike@pixelcog.com>2018-03-12 18:00:44 -0500
commitf3d3a4719d0b42e740e2c95e7d4a0198272872ad (patch)
tree6768843d137d7fde408316dbfb4e02184b25b8ad
parent9f9257fa5ab5fe1dafc4be4aa5bd9a5dbc9323cd (diff)
downloadgitlab-ce-43720-update-fe-webpack-docs.tar.gz
move tip into blockquote43720-update-fe-webpack-docs
-rw-r--r--doc/development/fe_guide/performance.md13
1 files changed, 5 insertions, 8 deletions
diff --git a/doc/development/fe_guide/performance.md b/doc/development/fe_guide/performance.md
index 5c3936fe1cc..1320efaf767 100644
--- a/doc/development/fe_guide/performance.md
+++ b/doc/development/fe_guide/performance.md
@@ -75,15 +75,12 @@ bundle and included on the page.
> manually generated webpack bundles. However under this new system you should
> not ever need to manually add an entry point to the `webpack.config.js` file.
-In addition to these page-specific bundles, the code within `main.js` and
-`commons/index.js` are imported on _all_ pages.
+> **Tip:**
+> If you are unsure what controller and action corresponds to a given page, you
+> can find this out by inspecting `document.body.dataset.page` within your
+> browser's developer console while on any page within gitlab.
-#### Important Tips and Considerations:
-
-- **Identifying Controller Paths:**
- If you are unsure what controller and action corresponds to a given page, you
- can find this out by inspecting `document.body.dataset.page` within your
- browser's developer console while on any page within gitlab.
+#### Important Considerations:
- **Keep Entry Points Lite:**
Page-specific javascript entry points should be as lite as possible. These