summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorImre Farkas <ifarkas@gitlab.com>2018-06-22 15:13:31 +0200
committerImre Farkas <ifarkas@gitlab.com>2018-06-25 10:55:18 +0200
commit8afd843992a7d9c9d1558d14dbd6ba48cb2cc0cf (patch)
tree5c19062d7d7f60f247d586f7c2e701b28f543274
parent9c3214640cfb572af3cc419d159c11bcd5b5e624 (diff)
downloadgitlab-ce-46963-add_readme_button_for_non_empty_project.tar.gz
Add readme button to non-empty project page46963-add_readme_button_for_non_empty_project
-rw-r--r--app/presenters/project_presenter.rb1
-rw-r--r--changelogs/unreleased/46963-add_readme_button_for_non_empty_project.yml5
-rw-r--r--spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb9
3 files changed, 15 insertions, 0 deletions
diff --git a/app/presenters/project_presenter.rb b/app/presenters/project_presenter.rb
index ad655a7b3f4..0eac8e494ce 100644
--- a/app/presenters/project_presenter.rb
+++ b/app/presenters/project_presenter.rb
@@ -27,6 +27,7 @@ class ProjectPresenter < Gitlab::View::Presenter::Delegated
def statistics_buttons(show_auto_devops_callout:)
[
+ readme_anchor_data,
changelog_anchor_data,
license_anchor_data,
contribution_guide_anchor_data,
diff --git a/changelogs/unreleased/46963-add_readme_button_for_non_empty_project.yml b/changelogs/unreleased/46963-add_readme_button_for_non_empty_project.yml
new file mode 100644
index 00000000000..1297cacc422
--- /dev/null
+++ b/changelogs/unreleased/46963-add_readme_button_for_non_empty_project.yml
@@ -0,0 +1,5 @@
+---
+title: Add readme button to non-empty project page
+merge_request:
+author:
+type: fixed
diff --git a/spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb b/spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb
index e44361fbe26..3c72eb8e27e 100644
--- a/spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb
+++ b/spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb
@@ -145,6 +145,15 @@ describe 'Projects > Show > User sees setup shortcut buttons' do
visit project_path(project)
end
+ it 'no "Add Readme" button if the project already has a readme' do
+ expect(project.repository.readme).not_to be_nil
+
+ page.within('.project-stats') do
+ expect(page).not_to have_link('Add Readme', href: presenter.add_readme_path)
+ expect(page).to have_link('Readme', href: presenter.readme_path)
+ end
+ end
+
it 'no "Add Changelog" button if the project already has a changelog' do
expect(project.repository.changelog).not_to be_nil