diff options
| author | Eric Eastwood <contact@ericeastwood.com> | 2018-06-18 19:00:25 -0500 |
|---|---|---|
| committer | Eric Eastwood <contact@ericeastwood.com> | 2018-06-18 19:00:25 -0500 |
| commit | c46ff7de67d31bfc8875abf58d0fd096b6d725ae (patch) | |
| tree | 92a282b83f83a05c68a994d783d83d486c1d1f73 | |
| parent | 69966fcb8d19f0ce219a498efb2855902a2895b1 (diff) | |
| download | gitlab-ce-48093-fix-flakey-notes-background-process-specs.tar.gz | |
Fix flakey time-sensitive specs that rely on notes background Sidekiq jobs48093-fix-flakey-notes-background-process-specs
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/48093
We use `perform_enqueued_jobs` because it is "adapter-agnostic so it's better to use it over Sidekiq::Testing.inline!." -- https://gitlab.com/gitlab-org/gitlab-ce/issues/22991
| -rw-r--r-- | spec/support/helpers/features/notes_helpers.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/support/helpers/features/notes_helpers.rb b/spec/support/helpers/features/notes_helpers.rb index 1a1d5853a7a..2b9f8b30c60 100644 --- a/spec/support/helpers/features/notes_helpers.rb +++ b/spec/support/helpers/features/notes_helpers.rb @@ -13,7 +13,7 @@ module Spec module Features module NotesHelpers def add_note(text) - Sidekiq::Testing.fake! do + perform_enqueued_jobs do page.within(".js-main-target-form") do fill_in("note[note]", with: text) find(".js-comment-submit-button").click |