summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjerasmus <jerasmus@gitlab.com>2019-02-07 11:34:58 +0200
committerjerasmus <jerasmus@gitlab.com>2019-02-07 11:34:58 +0200
commitf1ea16dd59e0c9c193e90eff123805602165da6f (patch)
tree5c243b48ed68eeef8b3aec1850ee285a68301ca3
parente2ce6fe50a961fe664601dd608dc73aa4f785d3f (diff)
downloadgitlab-ce-49384-upgrade-runner-fe.tar.gz
Address review comments49384-upgrade-runner-fe
Minor fixes from review comments
-rw-r--r--app/assets/javascripts/clusters/clusters_bundle.js2
-rw-r--r--locale/gitlab.pot4
2 files changed, 4 insertions, 2 deletions
diff --git a/app/assets/javascripts/clusters/clusters_bundle.js b/app/assets/javascripts/clusters/clusters_bundle.js
index 2da7f5d4051..6ebd1ad109e 100644
--- a/app/assets/javascripts/clusters/clusters_bundle.js
+++ b/app/assets/javascripts/clusters/clusters_bundle.js
@@ -135,6 +135,8 @@ export default class Clusters {
if (this.showTokenButton) this.showTokenButton.removeEventListener('click', this.showToken);
eventHub.$off('installApplication', this.installApplication);
eventHub.$off('upgradeApplication', this.upgradeApplication);
+ eventHub.$off('upgradeFailed', this.upgradeFailed);
+ eventHub.$off('dismissUpgradeSuccess', this.dismissUpgradeSuccess);
}
initPolling() {
diff --git a/locale/gitlab.pot b/locale/gitlab.pot
index 8138639592e..a6f2f53a13e 100644
--- a/locale/gitlab.pot
+++ b/locale/gitlab.pot
@@ -1953,10 +1953,10 @@ msgstr ""
msgid "ClusterIntegration|Upgrade"
msgstr ""
-msgid "ClusterIntegration|Upgrade failed "
+msgid "ClusterIntegration|Upgrade failed"
msgstr ""
-msgid "ClusterIntegration|Upgraded "
+msgid "ClusterIntegration|Upgraded"
msgstr ""
msgid "ClusterIntegration|Upgrading"