summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Wortschack <mwortschack@gitlab.com>2018-11-05 09:32:28 +0100
committerMartin Wortschack <mwortschack@gitlab.com>2018-11-05 09:32:28 +0100
commit9a5339a9abb55a92df5aaf6b92142d2c2a006bec (patch)
treef25eef81b636614171a284834d1efdc68ed93943
parenta05da7908d800741e55022959fc36e77ed0212cd (diff)
downloadgitlab-ce-49403-redesign-activity-feed.tar.gz
Use captuer and concat in helper49403-redesign-activity-feed
-rw-r--r--app/helpers/events_helper.rb11
1 files changed, 3 insertions, 8 deletions
diff --git a/app/helpers/events_helper.rb b/app/helpers/events_helper.rb
index 58449dae9bc..2adfc04deb8 100644
--- a/app/helpers/events_helper.rb
+++ b/app/helpers/events_helper.rb
@@ -163,15 +163,10 @@ module EventsHelper
def event_note_title_html(event)
if event.note_target
- output = []
-
- output << content_tag(:span, class: "event-target-type append-right-4") do
- "#{event.note_target_type}"
+ capture do
+ concat content_tag(:span, event.note_target_type, class: "event-target-type append-right-4")
+ concat link_to(event.note_target_reference, event_note_target_url(event), title: event.target_title, class: 'has-tooltip event-target-link append-right-4')
end
-
- output << link_to(event.note_target_reference, event_note_target_url(event), title: event.target_title, class: 'has-tooltip event-target-link append-right-4')
-
- output.join.html_safe
else
content_tag(:strong, '(deleted)')
end