diff options
author | Thong Kuah <tkuah@gitlab.com> | 2018-08-15 17:18:56 +1200 |
---|---|---|
committer | Thong Kuah <tkuah@gitlab.com> | 2018-08-15 17:20:55 +1200 |
commit | 446af7238bea84d3282dd0a53e0b274739957b83 (patch) | |
tree | b98fcf5645029ea7b8c70f6c0647e267635f557b | |
parent | 6343964b9c7acac25d946545778c8ae6523773da (diff) | |
download | gitlab-ce-50323-fix-clusters-application-prometheus-test.tar.gz |
Convert the #install_command spec to promethus#install_command as the subject50323-fix-clusters-application-prometheus-test
This makes this consistent with the specs for other applications as
well as fixing a bug in the 'application failed to install previously'
spec
-rw-r--r-- | spec/models/clusters/applications/prometheus_spec.rb | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/spec/models/clusters/applications/prometheus_spec.rb b/spec/models/clusters/applications/prometheus_spec.rb index 7454be3ab2f..26b75c75e1d 100644 --- a/spec/models/clusters/applications/prometheus_spec.rb +++ b/spec/models/clusters/applications/prometheus_spec.rb @@ -154,20 +154,17 @@ describe Clusters::Applications::Prometheus do end describe '#install_command' do - let(:kubeclient) { double('kubernetes client') } let(:prometheus) { create(:clusters_applications_prometheus) } - it 'returns an instance of Gitlab::Kubernetes::Helm::InstallCommand' do - expect(prometheus.install_command).to be_an_instance_of(Gitlab::Kubernetes::Helm::InstallCommand) - end + subject { prometheus.install_command } - it 'should be initialized with 3 arguments' do - command = prometheus.install_command + it { is_expected.to be_an_instance_of(Gitlab::Kubernetes::Helm::InstallCommand) } - expect(command.name).to eq('prometheus') - expect(command.chart).to eq('stable/prometheus') - expect(command.version).to eq('6.7.3') - expect(command.files).to eq(prometheus.files) + it 'should be initialized with 3 arguments' do + expect(subject.name).to eq('prometheus') + expect(subject.chart).to eq('stable/prometheus') + expect(subject.version).to eq('6.7.3') + expect(subject.files).to eq(prometheus.files) end context 'application failed to install previously' do |