summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSteve Azzopardi <steveazz@outlook.com>2018-10-29 18:18:42 +0100
committerSteve Azzopardi <steveazz@outlook.com>2018-10-29 18:18:42 +0100
commit189c676fe08f4d5fb2b0daf167d0934d39c4c135 (patch)
tree8d49a9e36589dfef85f9a9c5bb543df4b765dd9e
parent05af98bfefba87f60eda58642a6422af10c129ae (diff)
downloadgitlab-ce-51197-create-json-schema-for-environments-controller-index.tar.gz
Add JSON schema for EnvironmentsController::index51197-create-json-schema-for-environments-controller-index
Add missing JSON schema validation in spec.
-rw-r--r--spec/controllers/projects/environments_controller_spec.rb4
-rw-r--r--spec/fixtures/api/schemas/environments.json23
2 files changed, 27 insertions, 0 deletions
diff --git a/spec/controllers/projects/environments_controller_spec.rb b/spec/controllers/projects/environments_controller_spec.rb
index b86029a4baf..d389dbb50e5 100644
--- a/spec/controllers/projects/environments_controller_spec.rb
+++ b/spec/controllers/projects/environments_controller_spec.rb
@@ -69,6 +69,10 @@ describe Projects::EnvironmentsController do
expect(response).to have_gitlab_http_status(:ok)
expect(response.headers['Poll-Interval']).to eq("3000")
end
+
+ it 'matches json schema' do
+ expect(response).to match_response_schema('environments')
+ end
end
context 'when requesting stopped environments scope' do
diff --git a/spec/fixtures/api/schemas/environments.json b/spec/fixtures/api/schemas/environments.json
new file mode 100644
index 00000000000..29a5d23b219
--- /dev/null
+++ b/spec/fixtures/api/schemas/environments.json
@@ -0,0 +1,23 @@
+{
+ "types": "object",
+ "required": [
+ "environments",
+ "available_count",
+ "stopped_count"
+ ],
+ "properties": {
+ "environments": {
+ "type": "array",
+ "items": {
+ "type": "object",
+ "properties": {
+ "name": { "type": "string" },
+ "size": { "type": "integer"},
+ "latest": { "$ref": "environment.json"}
+ }
+ }
+ },
+ "available_count": { "type": "integer" },
+ "stopped_count": { "type": "integer" }
+ }
+}