diff options
| author | Rémy Coutable <remy@rymai.me> | 2018-11-09 12:30:49 +0100 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-11-09 12:30:51 +0100 |
| commit | f7f42cf34553f93c875186f61efc5909d0099cd4 (patch) | |
| tree | 4d280faa50101c256f1cab4c9694f38871a00f6b | |
| parent | ef58a64039c517be7df08eef1b3a7af7ad5eab16 (diff) | |
| download | gitlab-ce-53621-review-app-credentials-does-not-reliably-work.tar.gz | |
Ensure we create the secrets at the right time53621-review-app-credentials-does-not-reliably-work
In `deploy`, if the previous deployment failed, we delete/cleanup all
the objects related to the release, including secrets. The problem is
that if we create the root password before that, it will be then
recreated during the deploy with a random value!
By creatigng the secret just before actually deplying a new release, we
ensure that it won't be overriden.
Signed-off-by: Rémy Coutable <remy@rymai.me>
| -rw-r--r-- | .gitlab-ci.yml | 1 | ||||
| -rwxr-xr-x | scripts/review_apps/review-apps.sh | 3 |
2 files changed, 3 insertions, 1 deletions
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0e7a67f9cc1..407cd8696a2 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -954,7 +954,6 @@ review: - download_gitlab_chart - ensure_namespace - install_tiller - - create_secret - install_external_dns - deploy environment: diff --git a/scripts/review_apps/review-apps.sh b/scripts/review_apps/review-apps.sh index d372bcbdab1..016682e5a3d 100755 --- a/scripts/review_apps/review-apps.sh +++ b/scripts/review_apps/review-apps.sh @@ -126,6 +126,9 @@ function deploy() { delete cleanup fi + + create_secret + helm repo add gitlab https://charts.gitlab.io/ helm dep update . |