diff options
| author | Paul Slaughter <pslaughter@gitlab.com> | 2019-05-07 14:05:59 -0500 |
|---|---|---|
| committer | Paul Slaughter <pslaughter@gitlab.com> | 2019-05-07 15:41:00 -0500 |
| commit | 00b2e9ba3565505fb10a36331e6e07e636c03424 (patch) | |
| tree | 36a2981e99277b4cd90b6178d4484bada0779c5e | |
| parent | cf5c8e73fb046e9db166f7115478d04d7774fd19 (diff) | |
| download | gitlab-ce-53973-fix-subpixel-border-issue.tar.gz | |
Fix subpixel border issue53973-fix-subpixel-border-issue
**What?**
In some browsers subpixel heights are rounded in tables.
This was causing the discussion border to be hidden because the
content overflowed.
Adding `padding-bottom: 1px` basically overrides this rounding.
https://gitlab.com/gitlab-org/gitlab-ce/issues/53973
| -rw-r--r-- | app/assets/stylesheets/pages/notes.scss | 5 | ||||
| -rw-r--r-- | changelogs/unreleased/53973-fix-subpixel-border-issue.yml | 5 |
2 files changed, 10 insertions, 0 deletions
diff --git a/app/assets/stylesheets/pages/notes.scss b/app/assets/stylesheets/pages/notes.scss index 09f75cd827f..f2b67a693c3 100644 --- a/app/assets/stylesheets/pages/notes.scss +++ b/app/assets/stylesheets/pages/notes.scss @@ -471,6 +471,11 @@ $note-form-margin-left: 72px; vertical-align: top; white-space: normal; + // Fixes subpixel rounding issue https://gitlab.com/gitlab-org/gitlab-ce/issues/53973 + // background-color is needed for dark code preference + padding-bottom: 1px; + background-color: $white-light; + &.parallel { border-width: 1px; diff --git a/changelogs/unreleased/53973-fix-subpixel-border-issue.yml b/changelogs/unreleased/53973-fix-subpixel-border-issue.yml new file mode 100644 index 00000000000..0dae7047236 --- /dev/null +++ b/changelogs/unreleased/53973-fix-subpixel-border-issue.yml @@ -0,0 +1,5 @@ +--- +title: Fix MR discussion border missing in chrome sometimes +merge_request: 28185 +author: +type: fixed |