diff options
author | Ezekiel Kigbo <ekigbo@gitlab.com> | 2019-06-12 00:17:17 +1000 |
---|---|---|
committer | Ezekiel Kigbo <ekigbo@gitlab.com> | 2019-07-10 13:54:42 +1000 |
commit | 8a4850fcbd6b4e7d70dc534427032b913d84716a (patch) | |
tree | 7b4d5211d17478b61519e391cd0320a1f8a801c0 | |
parent | b94e1c6bed9a659ec54f6894feb77238d869104f (diff) | |
download | gitlab-ce-54918-new-project-wizard-flow.tar.gz |
Replace jquery calls and selectors54918-new-project-wizard-flow
-rw-r--r-- | app/assets/javascripts/projects/project_new.js | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/app/assets/javascripts/projects/project_new.js b/app/assets/javascripts/projects/project_new.js index 875a2f12a47..72087220f8c 100644 --- a/app/assets/javascripts/projects/project_new.js +++ b/app/assets/javascripts/projects/project_new.js @@ -65,14 +65,14 @@ const getProjectVisibilityLevel = ( ) => $(projectVisibilitySelector).val(); function updateFeatureVisibilityOptions( - visibilitySelector, // jquery element + visibilitySelector, projectVisibilityLevel, featureEnabled = false, ) { if (featureEnabled && projectVisibilityLevel > 0) { - visibilitySelector.removeAttr('disabled'); + visibilitySelector.removeAttribute('disabled'); } else { - visibilitySelector.attr('disabled', 'disabled'); + visibilitySelector.setAttribute('disabled', 'disabled'); } const accessLevelOptions = getAccessLevelOptionsForFeature(featureEnabled); @@ -91,23 +91,23 @@ function updateFeatureVisibilityOptions( function onToggleFeatureSetting(featureEnabled, toggle) { const projectVisibilityLevel = getProjectVisibilityLevel(); - const toggleContext = $(toggle).closest('.js-project-feature-controls'); - const visibilitySelector = $('.js-project-repo-select', toggleContext); + const toggleContext = toggle.closest('.js-project-feature-controls'); + const visibilitySelector = toggleContext.querySelector('.js-project-repo-select'); updateFeatureVisibilityOptions(visibilitySelector, projectVisibilityLevel, featureEnabled); - $(toggle).attr( + toggle.setAttribute( 'aria-label', featureEnabled ? s__('Toggle Status: ON') : s__('Toggle Status: OFF'), ); } -function onProjectVisitbilityChange(featureSelectors) { +function onProjectVisibilityChange(featureSelectors) { const projectVisibilityLevel = getProjectVisibilityLevel(); featureSelectors.forEach(context => { const featureEnabled = parseBoolean( context.querySelector('.js-project-feature-toggle-input').getAttribute('value'), ); - const visibilitySelector = $('.js-project-repo-select', context); + const visibilitySelector = context.querySelector('.js-project-repo-select'); updateFeatureVisibilityOptions(visibilitySelector, projectVisibilityLevel, featureEnabled); }); } @@ -304,11 +304,14 @@ const bindEvents = () => { }); if (window.gon.features && window.gon.features.newProjectAdvancedFields) { - const $projectVisibilityLevel = $( + const $projectVisibilityLevelSetting = document.querySelectorAll( '.visibility-level-setting [name="project[visibility_level]"]', ); + const $projectFeatures = document.querySelectorAll('.js-project-feature-row'); - $projectVisibilityLevel.on('change', () => onProjectVisitbilityChange($projectFeatures)); + $projectVisibilityLevelSetting.forEach(setting => { + setting.addEventListener('change', () => onProjectVisibilityChange($projectFeatures)); + }); initSettingsPanels({ expandedPanelText: s__('Hide avatar, license and features settings'), |