diff options
author | Ryan Cobb <rcobb@gitlab.com> | 2019-07-26 15:50:22 -0600 |
---|---|---|
committer | Ryan Cobb <rcobb@gitlab.com> | 2019-07-26 15:50:22 -0600 |
commit | fa7d31b58e43a5dddb819d651bb5d27037ec3349 (patch) | |
tree | 4b9bde20c8746fae15244ef9ea9dbb7d138e1827 | |
parent | fec78ad98e559d568ff51ed9701cbcc28bf630f1 (diff) | |
download | gitlab-ce-56752-replace-sidekiq-metrics.tar.gz |
Use Benchmark.realtime to measure job time56752-replace-sidekiq-metrics
-rw-r--r-- | lib/gitlab/sidekiq_middleware/metrics.rb | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/gitlab/sidekiq_middleware/metrics.rb b/lib/gitlab/sidekiq_middleware/metrics.rb index 6d24ce8445f..b06ffa9c121 100644 --- a/lib/gitlab/sidekiq_middleware/metrics.rb +++ b/lib/gitlab/sidekiq_middleware/metrics.rb @@ -15,12 +15,11 @@ module Gitlab @metrics[:sidekiq_jobs_retried_total].increment(labels, 1) end - benchmark = Benchmark.measure do + realtime = Benchmark.realtime do yield end - @metrics[:sidekiq_jobs_completion_seconds].observe(labels, benchmark.real) - Sidekiq.logger.info(user_time: benchmark.utime + benchmark.cutime, system_time: benchmark.stime + benchmark.cstime) + @metrics[:sidekiq_jobs_completion_seconds].observe(labels, realtime) rescue Exception # rubocop: disable Lint/RescueException @metrics[:sidekiq_jobs_failed_total].increment(labels, 1) raise |