Merge branch 'fix-false-positive-specs' into 'master'57092-geo-clone-button-should-check-for-geo

Fix false positive specs

See merge request gitlab-org/gitlab-ce!26031

2 files changed, 3 insertions, 16 deletions

diff --git a/spec/features/security/group/private_access_spec.rb b/spec/features/security/group/private_access_spec.rb
index de38a2c0204..a776169a8e5 100644
--- a/spec/features/security/group/private_access_spec.rb
+++ b/spec/features/security/group/private_access_spec.rb
@@ -98,11 +98,7 @@ describe 'Private Group access' do
     let(:project) { create(:project, :public) }
 
     before do
-      Projects::GroupLinks::CreateService.new(
-        project,
-        create(:user),
-        link_group_access: ProjectGroupLink::DEVELOPER
-      ).execute(group)
+      create(:project_group_link, project: project, group: group)
     end
 
     subject { group_path(group) }
diff --git a/spec/policies/group_policy_spec.rb b/spec/policies/group_policy_spec.rb
index 0ad50c6f91f..92bdaa8b8b8 100644
--- a/spec/policies/group_policy_spec.rb
+++ b/spec/policies/group_policy_spec.rb
@@ -76,15 +76,10 @@ describe GroupPolicy do
 
   context 'with no user and public project' do
     let(:project) { create(:project, :public) }
-    let(:user) { create(:user) }
     let(:current_user) { nil }
 
     before do
-      Projects::GroupLinks::CreateService.new(
-        project,
-        user,
-        link_group_access: ProjectGroupLink::DEVELOPER
-      ).execute(group)
+      create(:project_group_link, project: project, group: group)
     end
 
     it { expect_disallowed(:read_group) }
@@ -96,11 +91,7 @@ describe GroupPolicy do
     let(:current_user) { create(:user) }
 
     before do
-      Projects::GroupLinks::CreateService.new(
-        project,
-        user,
-        link_group_access: ProjectGroupLink::DEVELOPER
-      ).execute(group)
+      create(:project_group_link, project: project, group: group)
     end
 
     it { expect_disallowed(:read_group) }