summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrpereira2 <rpereira@gitlab.com>2019-03-29 17:57:31 +0530
committerrpereira2 <rpereira@gitlab.com>2019-03-29 17:57:31 +0530
commit6657e264a1a2d1cf4a046b221a502fad647e0302 (patch)
treec6e7229b4b4ce2af3ce1fcd102e8e2721ef8f486
parentb43f3983a973692c4e278a4122e7c50fab5b93b7 (diff)
downloadgitlab-ce-58971-sentry-api-keyerror.tar.gz
Use map instead of tap to make test setup clearer58971-sentry-api-keyerror
-rw-r--r--spec/lib/sentry/client_spec.rb17
1 files changed, 9 insertions, 8 deletions
diff --git a/spec/lib/sentry/client_spec.rb b/spec/lib/sentry/client_spec.rb
index ea6301913a7..3333f8307ae 100644
--- a/spec/lib/sentry/client_spec.rb
+++ b/spec/lib/sentry/client_spec.rb
@@ -144,8 +144,9 @@ describe Sentry::Client do
context 'Older sentry versions where keys are not present' do
let(:sentry_api_response) do
- [] << issues_sample_response[0].tap do |issue|
+ issues_sample_response[0...1].map do |issue|
issue[:project].delete(:id)
+ issue
end
end
@@ -159,8 +160,8 @@ describe Sentry::Client do
context 'essential keys missing in API response' do
let(:sentry_api_response) do
- [] << issues_sample_response[0].tap do |issue|
- issue.delete(:id)
+ issues_sample_response[0...1].map do |issue|
+ issue.except(:id)
end
end
@@ -186,8 +187,8 @@ describe Sentry::Client do
context 'essential keys missing in API response' do
let(:sentry_api_response) do
- [] << projects_sample_response[0].tap do |project|
- project.delete(:slug)
+ projects_sample_response[0...1].map do |project|
+ project.except(:slug)
end
end
@@ -198,10 +199,10 @@ describe Sentry::Client do
context 'optional keys missing in sentry response' do
let(:sentry_api_response) do
- [] << projects_sample_response[0].tap do |project|
- project.delete(:id)
- project.delete(:status)
+ projects_sample_response[0...1].map do |project|
project[:organization].delete(:id)
+ project.delete(:id)
+ project.except(:status)
end
end