summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Speicher <rspeicher@gmail.com>2019-06-06 19:24:08 +0000
committerRobert Speicher <rspeicher@gmail.com>2019-06-06 19:24:08 +0000
commit62b5fa41e592123794e8b9ee222b89db8efb0103 (patch)
tree5535f82ab1f1507c5605fc5b02e03120ae04ef9f
parent8cd197a0ddd1398bb84926da11c76dd1abdfa688 (diff)
parent1b2de25deeab172cabd8d74ad7fc60a4db39cbe5 (diff)
downloadgitlab-ce-62884-the-next-kn-service-deployed-don-t-get-fetched-due-to-reactivecaching.tar.gz
Merge branch 'dont-fail-danger-with-emojis' into 'master'62884-the-next-kn-service-deployed-don-t-get-fetched-due-to-reactivecaching
Don't fail the pipeline when a colon-emoji is used See merge request gitlab-org/gitlab-ce!29291
-rw-r--r--danger/commit_messages/Dangerfile4
1 files changed, 2 insertions, 2 deletions
diff --git a/danger/commit_messages/Dangerfile b/danger/commit_messages/Dangerfile
index 048c539bcf9..bdb4343b1d6 100644
--- a/danger/commit_messages/Dangerfile
+++ b/danger/commit_messages/Dangerfile
@@ -163,10 +163,10 @@ def lint_commit(commit)
end
if emoji_checker.includes_emoji?(commit.message)
- fail_commit(
+ warn_commit(
commit,
'Avoid the use of Markdown Emoji such as `:+1:`. ' \
- 'These add no value to the commit message, ' \
+ 'These add limited value to the commit message, ' \
'and are displayed as plain text outside of GitLab'
)