diff options
author | Paul Gascou-Vaillancourt <paul.gascvail@gmail.com> | 2019-06-26 08:33:04 -0400 |
---|---|---|
committer | Paul Gascou-Vaillancourt <paul.gascvail@gmail.com> | 2019-06-27 07:47:58 -0400 |
commit | 5c6db570781b207dd31c5e52546d2d0ac09980b6 (patch) | |
tree | 6fb413e289546321d3baedee99b9a3220473ed5f | |
parent | 210a0afaa306b788330834ea9ade68d54dde8cd3 (diff) | |
download | gitlab-ce-63200-reply-button-broken.tar.gz |
Apply review comments63200-reply-button-broken
-rw-r--r-- | spec/frontend/notes/components/discussion_notes_spec.js | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/spec/frontend/notes/components/discussion_notes_spec.js b/spec/frontend/notes/components/discussion_notes_spec.js index 964ee7ccb5c..394666403ee 100644 --- a/spec/frontend/notes/components/discussion_notes_spec.js +++ b/spec/frontend/notes/components/discussion_notes_spec.js @@ -114,26 +114,24 @@ describe('DiscussionNotes', () => { describe('events', () => { describe('with groupped notes and replies expanded', () => { - let firstNote; - let secondNote; + const findNoteAtIndex = index => wrapper.find(`.note:nth-of-type(${index + 1}`); + beforeEach(() => { createComponent({ shouldGroupReplies: true, isExpanded: true }); - const notes = wrapper.findAll('.note'); - [firstNote, secondNote] = [notes.at(0), notes.at(1)]; }); it('emits deleteNote when first note emits handleDeleteNote', () => { - firstNote.vm.$emit('handleDeleteNote'); + findNoteAtIndex(0).vm.$emit('handleDeleteNote'); expect(wrapper.emitted().deleteNote).toBeTruthy(); }); it('emits startReplying when first note emits startReplying', () => { - firstNote.vm.$emit('startReplying'); + findNoteAtIndex(0).vm.$emit('startReplying'); expect(wrapper.emitted().startReplying).toBeTruthy(); }); it('emits deleteNote when second note emits handleDeleteNote', () => { - secondNote.vm.$emit('handleDeleteNote'); + findNoteAtIndex(1).vm.$emit('handleDeleteNote'); expect(wrapper.emitted().deleteNote).toBeTruthy(); }); }); |