Reduce param reassignment64481-project-defined-metrics-dashboards-always-show-no-data-found-state

This commit reduces the param reassignment for a map
function, also adds the changelog entry

2 files changed, 22 insertions, 19 deletions

diff --git a/changelogs/unreleased/64481-project-defined-metrics-dashboards-always-show-no-data-found-state.yml b/changelogs/unreleased/64481-project-defined-metrics-dashboards-always-show-no-data-found-state.yml
new file mode 100644
index 00000000000..3c88d5863be
--- /dev/null
+++ b/changelogs/unreleased/64481-project-defined-metrics-dashboards-always-show-no-data-found-state.yml
@@ -0,0 +1,5 @@
+---
+title: Fix project defined dashboards not rendering
+merge_request: 30970
+author:
+type: fixed
diff --git a/spec/javascripts/monitoring/store/mutations_spec.js b/spec/javascripts/monitoring/store/mutations_spec.js
index 81fe1eab4d3..10614cabcf3 100644
--- a/spec/javascripts/monitoring/store/mutations_spec.js
+++ b/spec/javascripts/monitoring/store/mutations_spec.js
@@ -163,25 +163,23 @@ describe('Monitoring mutations', () => {
       expect(stateCopy.metricsWithData).toEqual([]);
     });
 
-    it('sets metricsWithData value when using the id field', () => {
-      stateCopy.groups.map(group => {
-        const modGroup = group;
-        const metrics = group.metrics.map(metric => {
-          const modMetric = metric;
-          const queries = metric.queries.map(query => {
-            const modQuery = query;
-
-            delete modQuery.metric_id;
-            return modQuery;
-          });
-
-          modMetric.queries = queries;
-          return modMetric;
-        });
-
-        modGroup.metrics = metrics;
-        return modGroup;
-      });
+    it('sets metricsWithData values when no metric_id is present but the id field is', () => {
+      stateCopy.groups.map(group => ({
+        group: {
+          ...group,
+          metrics: group.metrics.map(metric => ({
+            metric: {
+              ...metric,
+              queries: metric.queries.map(query => {
+                const queryNoMetricId = query;
+                delete queryNoMetricId.metric_id;
+
+                return queryNoMetricId;
+              }),
+            },
+          })),
+        },
+      }));
 
       mutations[types.SET_QUERY_RESULT](stateCopy, {
         metricId: 'system_metrics_kubernetes_container_memory_total',