summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2019-07-22 17:50:47 +0200
committerRémy Coutable <remy@rymai.me>2019-07-23 11:33:34 +0200
commitba1fcfcd5de9f22ff14e0246b17c1fe9d97f6f80 (patch)
tree23f506145eec1e61ddca6af1f557c3944b103d3f
parent9cffa428ad1b572437c38d7a3a41a26c35cc3576 (diff)
downloadgitlab-ce-64926-fix-review-app-shared-secrets-job.tar.gz
Fix usage of 'kubectl create secret generic' in review-apps.sh64926-fix-review-app-shared-secrets-job
Signed-off-by: Rémy Coutable <remy@rymai.me>
-rwxr-xr-xscripts/review_apps/review-apps.sh3
1 files changed, 2 insertions, 1 deletions
diff --git a/scripts/review_apps/review-apps.sh b/scripts/review_apps/review-apps.sh
index bc47884ee45..fc9b27d328d 100755
--- a/scripts/review_apps/review-apps.sh
+++ b/scripts/review_apps/review-apps.sh
@@ -156,8 +156,9 @@ function install_external_dns() {
function create_application_secret() {
echoinfo "Creating the ${CI_ENVIRONMENT_SLUG}-gitlab-initial-root-password secret in the ${KUBE_NAMESPACE} namespace..." true
- kubectl create secret generic -n "$KUBE_NAMESPACE" \
+ kubectl create secret generic \
"${CI_ENVIRONMENT_SLUG}-gitlab-initial-root-password" \
+ -n "$KUBE_NAMESPACE" \
--from-literal="password=${REVIEW_APPS_ROOT_PASSWORD}" \
--dry-run -o json | kubectl apply -f -
}