diff options
author | Paul Gascou-Vaillancourt <paul.gascvail@gmail.com> | 2019-07-15 14:55:20 -0400 |
---|---|---|
committer | Paul Gascou-Vaillancourt <paul.gascvail@gmail.com> | 2019-08-30 12:19:48 -0400 |
commit | 7c20c6fbb9b538f05f3c098bd06d368b1cb34a21 (patch) | |
tree | 5c609482911607ad2aa1b6a3dd545cc968803ad1 | |
parent | a0a6a2fd89bcc9bd16c9d00dee2076eb2169968e (diff) | |
download | gitlab-ce-8146-vuln-modal-refactor-backport.tar.gz |
Refactor vulnerability modal8146-vuln-modal-refactor-backport
- Moved modal's state into a dedicated module
- Moved following actions to modal's module:
- openModal
- setModalData
- openDismissalCommentBox
- closeDismissalCommentBox
- Created has_vulnerability_modal mixin
-rw-r--r-- | app/assets/javascripts/reports/components/modal_open_name.vue | 17 | ||||
-rw-r--r-- | spec/javascripts/reports/components/modal_open_name_spec.js | 8 |
2 files changed, 7 insertions, 18 deletions
diff --git a/app/assets/javascripts/reports/components/modal_open_name.vue b/app/assets/javascripts/reports/components/modal_open_name.vue index 4f81cee2a38..5afc72fa5cb 100644 --- a/app/assets/javascripts/reports/components/modal_open_name.vue +++ b/app/assets/javascripts/reports/components/modal_open_name.vue @@ -1,7 +1,11 @@ <script> -import { mapActions } from 'vuex'; - export default { + inject: { + handleIssueClick: { + from: 'handleIssueClick', + default: () => () => {}, + }, + }, props: { issue: { type: Object, @@ -13,20 +17,13 @@ export default { required: true, }, }, - methods: { - ...mapActions(['openModal']), - handleIssueClick() { - const { issue, status, openModal } = this; - openModal({ issue, status }); - }, - }, }; </script> <template> <button type="button" class="btn-link btn-blank text-left break-link vulnerability-name-button" - @click="handleIssueClick()" + @click="() => handleIssueClick({ issue, status })" > {{ issue.title }} </button> diff --git a/spec/javascripts/reports/components/modal_open_name_spec.js b/spec/javascripts/reports/components/modal_open_name_spec.js index b18b3ef03d1..f21b34f5894 100644 --- a/spec/javascripts/reports/components/modal_open_name_spec.js +++ b/spec/javascripts/reports/components/modal_open_name_spec.js @@ -34,12 +34,4 @@ describe('Modal open name', () => { it('renders the issue name', () => { expect(vm.$el.textContent.trim()).toEqual('Issue'); }); - - it('calls openModal actions when button is clicked', () => { - spyOn(vm, 'openModal'); - - vm.$el.click(); - - expect(vm.openModal).toHaveBeenCalled(); - }); }); |