summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLucas Charles <me@lucascharles.me>2019-07-10 08:36:55 -0700
committerLucas Charles <me@lucascharles.me>2019-07-15 13:46:44 -0700
commit7e050f396df616e9b19369330b811861652cf7e7 (patch)
tree15e1db17ddb36ab3767f6db991fac2c061dc0114
parentf69232d506f82434e8b180e776c5b377fd461559 (diff)
downloadgitlab-ce-9928ee-add-rule_type-to-approval-project-rules.tar.gz
Add rule_type to approval_project_rules9928ee-add-rule_type-to-approval-project-rules
Adds migration to introduce non-regular rule_types to approval_project_rules
-rw-r--r--changelogs/unreleased/9928ee-add-rule_type-to-approval-project-rules.yml5
-rw-r--r--db/migrate/20190709204413_add_rule_type_to_approval_project_rules.rb17
-rw-r--r--db/migrate/20190710151229_add_index_to_approval_project_rules_rule_type.rb17
-rw-r--r--db/schema.rb4
4 files changed, 42 insertions, 1 deletions
diff --git a/changelogs/unreleased/9928ee-add-rule_type-to-approval-project-rules.yml b/changelogs/unreleased/9928ee-add-rule_type-to-approval-project-rules.yml
new file mode 100644
index 00000000000..698ecebb971
--- /dev/null
+++ b/changelogs/unreleased/9928ee-add-rule_type-to-approval-project-rules.yml
@@ -0,0 +1,5 @@
+---
+title: Add migration for adding rule_type to approval_project_rules
+merge_request: 30575
+author:
+type: added
diff --git a/db/migrate/20190709204413_add_rule_type_to_approval_project_rules.rb b/db/migrate/20190709204413_add_rule_type_to_approval_project_rules.rb
new file mode 100644
index 00000000000..87a228c9bf9
--- /dev/null
+++ b/db/migrate/20190709204413_add_rule_type_to_approval_project_rules.rb
@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class AddRuleTypeToApprovalProjectRules < ActiveRecord::Migration[5.1]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+
+ disable_ddl_transaction!
+
+ def up
+ add_column_with_default :approval_project_rules, :rule_type, :integer, limit: 2, default: 0, allow_null: false
+ end
+
+ def down
+ remove_column :approval_project_rules, :rule_type
+ end
+end
diff --git a/db/migrate/20190710151229_add_index_to_approval_project_rules_rule_type.rb b/db/migrate/20190710151229_add_index_to_approval_project_rules_rule_type.rb
new file mode 100644
index 00000000000..64123c53c4a
--- /dev/null
+++ b/db/migrate/20190710151229_add_index_to_approval_project_rules_rule_type.rb
@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class AddIndexToApprovalProjectRulesRuleType < ActiveRecord::Migration[5.1]
+ include Gitlab::Database::MigrationHelpers
+
+ DOWNTIME = false
+
+ disable_ddl_transaction!
+
+ def up
+ add_concurrent_index :approval_project_rules, :rule_type
+ end
+
+ def down
+ remove_concurrent_index :approval_project_rules, :rule_type
+ end
+end
diff --git a/db/schema.rb b/db/schema.rb
index 9d28c5d2383..32879e52b69 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema.define(version: 2019_07_03_130053) do
+ActiveRecord::Schema.define(version: 2019_07_10_151229) do
# These are extensions that must be enabled in order to support this database
enable_extension "pg_trgm"
@@ -282,7 +282,9 @@ ActiveRecord::Schema.define(version: 2019_07_03_130053) do
t.integer "project_id", null: false
t.integer "approvals_required", limit: 2, default: 0, null: false
t.string "name", null: false
+ t.integer "rule_type", limit: 2, default: 0, null: false
t.index ["project_id"], name: "index_approval_project_rules_on_project_id", using: :btree
+ t.index ["rule_type"], name: "index_approval_project_rules_on_rule_type", using: :btree
end
create_table "approval_project_rules_groups", force: :cascade do |t|