diff options
| author | Andreas Brandl <abrandl@gitlab.com> | 2019-09-12 13:01:06 +0200 |
|---|---|---|
| committer | Andreas Brandl <abrandl@gitlab.com> | 2019-09-12 13:01:31 +0200 |
| commit | 3a86a7d1fdc247c3accfadca9dc3bc1dc5615640 (patch) | |
| tree | a9e412b8badbb90b4ffe151472561d1a135efba9 | |
| parent | c5ed8c915c440fd06b845d383a73dd5355a7893d (diff) | |
| download | gitlab-ce-ab/rubocop-add-reference.tar.gz | |
Ignore add_reference rubocop offenses for existing migrationsab/rubocop-add-reference
4 files changed, 8 insertions, 2 deletions
diff --git a/db/migrate/20190611161641_add_target_project_id_to_merge_trains.rb b/db/migrate/20190611161641_add_target_project_id_to_merge_trains.rb index c200208e4c3..553e9371ab3 100644 --- a/db/migrate/20190611161641_add_target_project_id_to_merge_trains.rb +++ b/db/migrate/20190611161641_add_target_project_id_to_merge_trains.rb @@ -6,9 +6,9 @@ class AddTargetProjectIdToMergeTrains < ActiveRecord::Migration[5.1] DOWNTIME = false def change - # rubocop: disable Rails/NotNullColumn + # rubocop:disable Rails/NotNullColumn, Migration/AddReference add_reference :merge_trains, :target_project, null: false, index: true, foreign_key: { on_delete: :cascade, to_table: :projects }, type: :integer add_column :merge_trains, :target_branch, :text, null: false - # rubocop: enable Rails/NotNullColumn + # rubocop:enable Rails/NotNullColumn, Migration/AddReference end end diff --git a/db/migrate/20190712040400_add_environment_id_to_clusters_kubernetes_namespaces.rb b/db/migrate/20190712040400_add_environment_id_to_clusters_kubernetes_namespaces.rb index 5ab5a9ba2f8..7f465c0a962 100644 --- a/db/migrate/20190712040400_add_environment_id_to_clusters_kubernetes_namespaces.rb +++ b/db/migrate/20190712040400_add_environment_id_to_clusters_kubernetes_namespaces.rb @@ -4,7 +4,9 @@ class AddEnvironmentIdToClustersKubernetesNamespaces < ActiveRecord::Migration[5 DOWNTIME = false def change + # rubocop:disable Migration/AddReference add_reference :clusters_kubernetes_namespaces, :environment, index: true, type: :bigint, foreign_key: { on_delete: :nullify } + # rubocop:enable Migration/AddReference end end diff --git a/db/migrate/20190715042813_add_issue_id_to_versions.rb b/db/migrate/20190715042813_add_issue_id_to_versions.rb index 1cefdbc9df2..623e72c1096 100644 --- a/db/migrate/20190715042813_add_issue_id_to_versions.rb +++ b/db/migrate/20190715042813_add_issue_id_to_versions.rb @@ -4,7 +4,9 @@ class AddIssueIdToVersions < ActiveRecord::Migration[5.2] DOWNTIME = false def up + # rubocop:disable Migration/AddReference add_reference :design_management_versions, :issue, index: true, foreign_key: { on_delete: :cascade } + # rubocop:enable Migration/AddReference end def down diff --git a/db/migrate/20190724112147_add_column_for_self_monitoring_project_id.rb b/db/migrate/20190724112147_add_column_for_self_monitoring_project_id.rb index ce249a527e6..cf44804cdb4 100644 --- a/db/migrate/20190724112147_add_column_for_self_monitoring_project_id.rb +++ b/db/migrate/20190724112147_add_column_for_self_monitoring_project_id.rb @@ -4,11 +4,13 @@ class AddColumnForSelfMonitoringProjectId < ActiveRecord::Migration[5.2] DOWNTIME = false def change + # rubocop:disable Migration/AddReference add_reference( :application_settings, :instance_administration_project, index: { name: 'index_applicationsettings_on_instance_administration_project_id' }, foreign_key: { to_table: :projects, on_delete: :nullify } ) + # rubocop:enable Migration/AddReference end end |