Reduce Cognitive Complexity in EnvironmentStatusac-post-merge-pipeline

1 files changed, 7 insertions, 7 deletions

diff --git a/app/models/environment_status.rb b/app/models/environment_status.rb
index 41bd69ac441..a84871f7253 100644
--- a/app/models/environment_status.rb
+++ b/app/models/environment_status.rb
@@ -68,18 +68,18 @@ class EnvironmentStatus
   def self.build_environments_status(mr, user, pipeline)
     return [] unless pipeline.present?
 
-    find_environments(pipeline) do |environment|
-      next unless Ability.allowed?(user, :read_environment, environment)
-
+    find_environments(user, pipeline).map do |environment|
       EnvironmentStatus.new(environment, mr, pipeline.sha)
-    end.compact
+    end
   end
+  private_class_method :build_environments_status
 
-  def self.find_environments(pipeline, &blk)
+  def self.find_environments(user, pipeline)
     env_ids = Deployment.where(deployable: pipeline.builds).select(:environment_id)
 
-    Environment.available.where(id: env_ids).map do |environment|
-      blk.call(environment)
+    Environment.available.where(id: env_ids).select do |environment|
+      Ability.allowed?(user, :read_environment, environment)
     end
   end
+  private_class_method :find_environments
 end