diff options
| author | Clement Ho <ClemMakesApps@gmail.com> | 2018-02-12 09:57:08 -0600 |
|---|---|---|
| committer | Clement Ho <ClemMakesApps@gmail.com> | 2018-02-12 09:57:08 -0600 |
| commit | 69efa4e1e89863f1ff426420effef057725ca385 (patch) | |
| tree | b7f13a6476bb03eaeacdb4d26b9b3c990b48c7e0 | |
| parent | 721fab661de4a01c2d73e88bdd000dfe2e094ced (diff) | |
| download | gitlab-ce-add-maintainer-guideline.tar.gz | |
Add maintainers section to code review guidelinesadd-maintainer-guideline
| -rw-r--r-- | doc/development/code_review.md | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 7165b8062a7..7342fa6e192 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -69,6 +69,13 @@ request is up to one the project's maintainers, denoted on the mentioning them; this will ensure they see it if their notification level is set to "mentioned" and other people will understand they don't have to respond. +### Maintainers + +- Avoid merging bad code even if that means delaying the release of a feature +- In the unlikely event that bad code needs to be merged, the associated MR + should have a note from a maintainer mentioning that the code has technical + debt and will be fixed by X date, otherwise the MR will be reverted. + ### Having your code reviewed Please keep in mind that code review is a process that can take multiple |