summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2017-03-02 19:35:43 +0000
committerFilipa Lacerda <filipa@gitlab.com>2017-03-02 19:35:43 +0000
commit52e104b2a41d4bbc55853bc62045232fc29e5e57 (patch)
tree751cb8624cbbc5598aadf03acf7cc60a540f10d8
parent936215433dec7b1e5d67b980098b97a012219bae (diff)
downloadgitlab-ce-add-svg-loader.tar.gz
Changes after reviewadd-svg-loader
-rw-r--r--app/assets/javascripts/cycle_analytics/components/stage_plan_component.js.es67
-rw-r--r--app/assets/javascripts/cycle_analytics/components/stage_staging_component.js.es65
-rw-r--r--app/assets/javascripts/cycle_analytics/components/stage_test_component.js.es65
-rw-r--r--app/assets/javascripts/vue_pipelines_index/status.js.es610
4 files changed, 21 insertions, 6 deletions
diff --git a/app/assets/javascripts/cycle_analytics/components/stage_plan_component.js.es6 b/app/assets/javascripts/cycle_analytics/components/stage_plan_component.js.es6
index 32b13872aea..42e1bbce744 100644
--- a/app/assets/javascripts/cycle_analytics/components/stage_plan_component.js.es6
+++ b/app/assets/javascripts/cycle_analytics/components/stage_plan_component.js.es6
@@ -1,5 +1,5 @@
/* eslint-disable no-param-reassign */
-/* global Vue */
+import Vue from 'vue';
import iconCommit from '../svg/icon_commit.svg';
((global) => {
@@ -10,6 +10,11 @@ import iconCommit from '../svg/icon_commit.svg';
items: Array,
stage: Object,
},
+
+ data() {
+ return { iconCommit };
+ },
+
template: `
<div>
<div class="events-description">
diff --git a/app/assets/javascripts/cycle_analytics/components/stage_staging_component.js.es6 b/app/assets/javascripts/cycle_analytics/components/stage_staging_component.js.es6
index fd6e2516952..8fa63734cf1 100644
--- a/app/assets/javascripts/cycle_analytics/components/stage_staging_component.js.es6
+++ b/app/assets/javascripts/cycle_analytics/components/stage_staging_component.js.es6
@@ -1,5 +1,5 @@
/* eslint-disable no-param-reassign */
-/* global Vue */
+import Vue from 'vue';
import iconBranch from '../svg/icon_branch.svg';
((global) => {
@@ -10,6 +10,9 @@ import iconBranch from '../svg/icon_branch.svg';
items: Array,
stage: Object,
},
+ data() {
+ return { iconBranch };
+ },
template: `
<div>
<div class="events-description">
diff --git a/app/assets/javascripts/cycle_analytics/components/stage_test_component.js.es6 b/app/assets/javascripts/cycle_analytics/components/stage_test_component.js.es6
index 34729e70f5e..0015249cfaa 100644
--- a/app/assets/javascripts/cycle_analytics/components/stage_test_component.js.es6
+++ b/app/assets/javascripts/cycle_analytics/components/stage_test_component.js.es6
@@ -1,5 +1,5 @@
/* eslint-disable no-param-reassign */
-/* global Vue */
+import Vue from 'vue';
import iconBuildStatus from '../svg/icon_build_status.svg';
import iconBranch from '../svg/icon_branch.svg';
@@ -11,6 +11,9 @@ import iconBranch from '../svg/icon_branch.svg';
items: Array,
stage: Object,
},
+ data() {
+ return { iconBuildStatus, iconBranch };
+ },
template: `
<div>
<div class="events-description">
diff --git a/app/assets/javascripts/vue_pipelines_index/status.js.es6 b/app/assets/javascripts/vue_pipelines_index/status.js.es6
index a3e56bc3193..8d9f83ac113 100644
--- a/app/assets/javascripts/vue_pipelines_index/status.js.es6
+++ b/app/assets/javascripts/vue_pipelines_index/status.js.es6
@@ -46,13 +46,17 @@ import warningSvg from 'icons/_icon_status_warning.svg';
const { status } = this.pipeline.details;
return status.has_details ? status.details_path : false;
},
+
+ content() {
+ return `${this.svg} ${this.pipeline.details.status.text}`;
+ },
},
template: `
<td class="commit-link">
<a
- :class='cssClasses'
- :href='detailsPath'
- v-html="svg + pipeline.details.status.text">
+ :class="cssClasses"
+ :href="detailsPath"
+ v-html="content">
</a>
</td>
`,