summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThong Kuah <tkuah@gitlab.com>2019-05-27 12:51:48 +1200
committerThong Kuah <tkuah@gitlab.com>2019-05-28 14:26:43 +1200
commitff0ffffd694b5ecda7d1327f4075e6d6de737901 (patch)
tree5ef5f4c7c4335f27b42bfef5c46e950feafcd0ea
parent2b8d597f2f60243008f58ee63b2264fc72f12215 (diff)
downloadgitlab-ce-api_make_protected_boolean_type.tar.gz
Make protected attribute Boolean typeapi_make_protected_boolean_type
As documented in https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/api/project_level_variables.md#create-variable and it's a boolean in `db/schema.rb`
-rw-r--r--changelogs/unreleased/api_make_protected_boolean_type.yml5
-rw-r--r--lib/api/variables.rb4
2 files changed, 7 insertions, 2 deletions
diff --git a/changelogs/unreleased/api_make_protected_boolean_type.yml b/changelogs/unreleased/api_make_protected_boolean_type.yml
new file mode 100644
index 00000000000..765edea6427
--- /dev/null
+++ b/changelogs/unreleased/api_make_protected_boolean_type.yml
@@ -0,0 +1,5 @@
+---
+title: 'API: change protected attribute type to Boolean'
+merge_request: 28766
+author:
+type: other
diff --git a/lib/api/variables.rb b/lib/api/variables.rb
index 38ff1b3d9cf..6c61392ed63 100644
--- a/lib/api/variables.rb
+++ b/lib/api/variables.rb
@@ -54,7 +54,7 @@ module API
params do
requires :key, type: String, desc: 'The key of the variable'
requires :value, type: String, desc: 'The value of the variable'
- optional :protected, type: String, desc: 'Whether the variable is protected'
+ optional :protected, type: Boolean, desc: 'Whether the variable is protected'
optional :masked, type: Boolean, desc: 'Whether the variable is masked'
optional :variable_type, type: String, values: Ci::Variable.variable_types.keys, desc: 'The type of variable, must be one of env_var or file. Defaults to env_var'
@@ -81,7 +81,7 @@ module API
params do
optional :key, type: String, desc: 'The key of the variable'
optional :value, type: String, desc: 'The value of the variable'
- optional :protected, type: String, desc: 'Whether the variable is protected'
+ optional :protected, type: Boolean, desc: 'Whether the variable is protected'
optional :masked, type: Boolean, desc: 'Whether the variable is masked'
optional :variable_type, type: String, values: Ci::Variable.variable_types.keys, desc: 'The type of variable, must be one of env_var or file'