summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlex Kalderimis <alex.kalderimis@gmail.com>2019-05-24 14:40:36 -0400
committerAlex Kalderimis <alex.kalderimis@gmail.com>2019-05-24 15:13:21 -0400
commit30c99f41d03baa7e540dc647463418c3758362b1 (patch)
tree8bd168a5a36dbda83cf2d197e625170c994a4022
parent57f4c26fd85b106da0fcef85ceb81fc393bb5bbe (diff)
downloadgitlab-ce-apply-symbolproc-cop.tar.gz
Better parameter nameapply-symbolproc-cop
the `file` parameter is not a file, it is the file content.
-rw-r--r--lib/gitlab/manifest_import/manifest.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/gitlab/manifest_import/manifest.rb b/lib/gitlab/manifest_import/manifest.rb
index e18521fcdd4..df785e94d2e 100644
--- a/lib/gitlab/manifest_import/manifest.rb
+++ b/lib/gitlab/manifest_import/manifest.rb
@@ -18,8 +18,8 @@ module Gitlab
class Manifest
attr_reader :parsed_xml, :errors
- def initialize(file)
- @parsed_xml = Nokogiri::XML(file, &:strict)
+ def initialize(file_contents)
+ @parsed_xml = Nokogiri::XML(file_contents, &:strict)
@errors = []
rescue Nokogiri::XML::SyntaxError
@errors = ['The uploaded file is not a valid XML file.']