diff options
| author | Ash McKenzie <amckenzie@gitlab.com> | 2019-09-13 16:15:43 +1000 |
|---|---|---|
| committer | Ash McKenzie <amckenzie@gitlab.com> | 2019-09-13 16:33:30 +1000 |
| commit | 6d5c15d2ca4ce0653ebcfc0c5a9f3ea962d7b9a8 (patch) | |
| tree | 170e217ac3b4ee18b91d73e11af3e5be8093a926 | |
| parent | 6f8ac067f547604a0bf0eb346f88f65daf8734dc (diff) | |
| download | gitlab-ce-ashmckenzie/add-reviewer-responsibility-section-docs.tar.gz | |
Add 'responsibility of the reviewer' sectionashmckenzie/add-reviewer-responsibility-section-docs
| -rw-r--r-- | doc/development/code_review.md | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index d55623521e1..ce9f794c1a3 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -127,6 +127,17 @@ through Slack). If you can't assign a merge request, `@` mentioning a maintainer This [saves reviewers time and helps authors catch mistakes earlier](https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/index.html#__RefHeading__97_174136755). +### The responsibility of the reviewer + +[Review the merge request](#reviewing-code) thoroughly. When you are confident +that it meets all requirements, you should: + +- Click the Approve button. +- Advise the author their merge request has been reviewed and approved. +- Assign the merge request to a maintainer. [Reviewer roulette](#reviewer-roulette) +should have made a suggestion, but feel free to override if someone else is a +better choice. + ### The responsibility of the maintainer Maintainers are responsible for the overall health, quality, and consistency of |