diff options
| author | Rémy Coutable <remy@rymai.me> | 2018-02-13 15:41:47 +0100 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-02-13 15:41:47 +0100 |
| commit | 64869433cd68b3f3678dc573c9103f3ec161a4a2 (patch) | |
| tree | 9fd83c5fa10a2c73377e80b01833e010aee0c5f8 | |
| parent | 7f4b14b104a377b3dbf294cf84038069ec704d0e (diff) | |
| download | gitlab-ce-ce-rc/move-all-ee-specs-to-ee-specs.tar.gz | |
Port some RuboCop and doc changes from EEce-rc/move-all-ee-specs-to-ee-specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
| -rw-r--r-- | .rubocop.yml | 26 | ||||
| -rw-r--r-- | doc/development/ee_features.md | 7 | ||||
| -rw-r--r-- | doc/development/testing_guide/testing_levels.md | 4 |
3 files changed, 32 insertions, 5 deletions
diff --git a/.rubocop.yml b/.rubocop.yml index 563a00db6c0..079fe9a5538 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -12,13 +12,24 @@ AllCops: - 'node_modules/**/*' - 'db/*' - 'db/fixtures/**/*' - - 'db/geo/*' + - 'ee/db/*' - 'tmp/**/*' - 'bin/**/*' - 'generator_templates/**/*' - 'builds/**/*' CacheRootDirectory: tmp +# This cop checks whether some constant value isn't a +# mutable literal (e.g. array or hash). +Style/MutableConstant: + Enabled: true + Exclude: + - 'db/migrate/**/*' + - 'db/post_migrate/**/*' + - 'ee/db/migrate/**/*' + - 'ee/db/post_migrate/**/*' + - 'ee/db/geo/migrate/**/*' + # Gitlab ################################################################### Gitlab/ModuleWithInstanceVariables: @@ -33,3 +44,16 @@ Gitlab/ModuleWithInstanceVariables: # We ignore spec helpers because it usually doesn't matter - spec/support/**/*.rb - features/steps/**/*.rb + +GitlabSecurity/PublicSend: + Enabled: true + Exclude: + - 'config/**/*' + - 'db/**/*' + - 'features/**/*' + - 'lib/**/*.rake' + - 'qa/**/*' + - 'spec/**/*' + - 'ee/db/**/*' + - 'ee/lib/**/*.rake' + - 'ee/spec/**/*' diff --git a/doc/development/ee_features.md b/doc/development/ee_features.md index f8cee89e650..f6a14de96b2 100644 --- a/doc/development/ee_features.md +++ b/doc/development/ee_features.md @@ -28,9 +28,8 @@ we still need to merge changes from GitLab CE to EE. To help us get there, we should make sure that we no longer edit CE files in place in order to implement EE features. -Instead, all EE codes should be put inside the `ee/` top-level directory, and -tests should be put inside `spec/ee/`. We don't use `ee/spec` for now due to -technical limitation. The rest of codes should be as close as to the CE files. +Instead, all EE code should be put inside the `ee/` top-level directory. The +rest of the code should be as close to the CE files as possible. [single code base]: https://gitlab.com/gitlab-org/gitlab-ee/issues/2952#note_41016454 @@ -318,7 +317,7 @@ When you're testing EE-only features, avoid adding examples to the existing CE specs. Also do no change existing CE examples, since they should remain working as-is when EE is running without a license. -Instead place EE specs in the `spec/ee/spec` folder. +Instead place EE specs in the `ee/spec` folder. ## JavaScript code in `assets/javascripts/` diff --git a/doc/development/testing_guide/testing_levels.md b/doc/development/testing_guide/testing_levels.md index 4adf0dc7c7a..e86c1f5232a 100644 --- a/doc/development/testing_guide/testing_levels.md +++ b/doc/development/testing_guide/testing_levels.md @@ -134,6 +134,10 @@ learn more. [GitLab QA]: https://gitlab.com/gitlab-org/gitlab-qa [part of GitLab Rails]: https://gitlab.com/gitlab-org/gitlab-ce/tree/master/qa +## EE-specific tests + +EE-specific tests follows the same organization, but under the `ee/spec` folder. + ## How to test at the correct level? As many things in life, deciding what to test at each level of testing is a |