diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2017-09-13 15:16:24 +0200 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2017-09-13 15:17:42 +0200 |
| commit | 9230caa907156354d6b9889eee1c4e30a4737471 (patch) | |
| tree | ad92f52a3e70f1fd4774d4fa219ec1b684eaa847 | |
| parent | f04094a4f8f8c307d05d3e8571cfcd44c586c599 (diff) | |
| download | gitlab-ce-ci-environment-status-performance.tar.gz | |
Disallow NULL values for environments.project_idci-environment-status-performance
| -rw-r--r-- | changelogs/unreleased/disallow-null-values-for-environments-project-id.yml | 5 | ||||
| -rw-r--r-- | db/migrate/20170913131410_environments_project_id_not_null.rb | 16 | ||||
| -rw-r--r-- | db/schema.rb | 4 |
3 files changed, 23 insertions, 2 deletions
diff --git a/changelogs/unreleased/disallow-null-values-for-environments-project-id.yml b/changelogs/unreleased/disallow-null-values-for-environments-project-id.yml new file mode 100644 index 00000000000..f4a956e6724 --- /dev/null +++ b/changelogs/unreleased/disallow-null-values-for-environments-project-id.yml @@ -0,0 +1,5 @@ +--- +title: "Disallow NULL values for environments.project_id" +merge_request: +author: +type: other diff --git a/db/migrate/20170913131410_environments_project_id_not_null.rb b/db/migrate/20170913131410_environments_project_id_not_null.rb new file mode 100644 index 00000000000..d5404f8ede9 --- /dev/null +++ b/db/migrate/20170913131410_environments_project_id_not_null.rb @@ -0,0 +1,16 @@ +# See http://doc.gitlab.com/ce/development/migration_style_guide.html +# for more information on how to write migrations for GitLab. + +class EnvironmentsProjectIdNotNull < ActiveRecord::Migration + include Gitlab::Database::MigrationHelpers + + DOWNTIME = false + + def up + change_column_null :environments, :project_id, false + end + + def down + change_column_null :environments, :project_id, true + end +end diff --git a/db/schema.rb b/db/schema.rb index 2149f5ad23d..dd0ef04788b 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -11,7 +11,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 20170905112933) do +ActiveRecord::Schema.define(version: 20170913131410) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" @@ -520,7 +520,7 @@ ActiveRecord::Schema.define(version: 20170905112933) do add_index "emails", ["user_id"], name: "index_emails_on_user_id", using: :btree create_table "environments", force: :cascade do |t| - t.integer "project_id" + t.integer "project_id", null: false t.string "name", null: false t.datetime "created_at" t.datetime "updated_at" |