summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean McGivern <sean@gitlab.com>2017-04-07 17:09:59 +0100
committerSean McGivern <sean@gitlab.com>2017-04-07 17:09:59 +0100
commit043a0ec0c79480ad1b110028d6f71be68859ccd2 (patch)
tree20a886f34eba7990b5fead6b4ebedb9be8c07d78
parent15e87cea3a374e8d929c28f6843170b182fe159a (diff)
downloadgitlab-ce-clarify-mr-with-someone.tar.gz
Clarify what an MR needs to be 'with' a maintainerclarify-mr-with-someone
-rw-r--r--PROCESS.md19
1 files changed, 14 insertions, 5 deletions
diff --git a/PROCESS.md b/PROCESS.md
index 2f331ee9169..cfa841dc13d 100644
--- a/PROCESS.md
+++ b/PROCESS.md
@@ -73,11 +73,20 @@ These types of merge requests need special consideration:
and a dedicated team with front-end, back-end, and UX.
* **Small features**: any other feature request.
-**Large features** must be with a maintainer **by the 1st**. It's OK if they
-aren't completely done, but this allows the maintainer enough time to make the
-decision about whether this can make it in before the freeze. If the maintainer
-doesn't think it will make it, they should inform the developers working on it
-and the Product Manager responsible for the feature.
+**Large features** must be with a maintainer **by the 1st**. This means that:
+
+* There is a merge request (even if it's WIP).
+* The person (or people, if it needs a frontend and backend maintainer) who will
+ ultimately be responsible for merging this have been pinged on the MR.
+
+It's OK if merge request isn't completely done, but this allows the maintainer
+enough time to make the decision about whether this can make it in before the
+freeze. If the maintainer doesn't think it will make it, they should inform the
+developers working on it and the Product Manager responsible for the feature.
+
+The maintainer can also choose to assign a reviewer to perform an initial
+review, but this way the maintainer is unlikely to be surprised by receiving an
+MR later in the cycle.
**Small features** must be with a reviewer (not necessarily maintainer) **by the
3rd**.