better naming and var palcementconfidential_issue_banner

1 files changed, 11 insertions, 4 deletions

diff --git a/app/assets/javascripts/confidential_issue.js b/app/assets/javascripts/confidential_issue.js
index 07068920be8..f68c5ad1987 100644
--- a/app/assets/javascripts/confidential_issue.js
+++ b/app/assets/javascripts/confidential_issue.js
@@ -1,3 +1,6 @@
+const CONFIDENTIAL_ISSUE_SCROLL_CLASS_NAME = 'confidential-issue-scroll';
+const CONFIDENTIAL_ISSUE_WARNING_SELECTOR = '.confidential-issue-warning';
+
 export default () => {
   /**
   * for IE11/Firefox/Edge :(
@@ -7,14 +10,18 @@ export default () => {
   * otherwise it will return a `truthy` value :)
   **/
 
-  const banner = document.querySelector('.confidential-issue-warning');
+  const banner = document.querySelector(CONFIDENTIAL_ISSUE_WARNING_SELECTOR);
   const bannerClassList = banner.classList;
 
   const confidentialScroll = () => {
-    if ((document.documentElement.scrollTop || document.body.scrollTop) > 5) {
-      bannerClassList.add('confidential-issue-scroll');
+    const scrollTop = (
+      document.documentElement.scrollTop || document.body.scrollTop
+    );
+
+    if (scrollTop > 5) {
+      bannerClassList.add(CONFIDENTIAL_ISSUE_SCROLL_CLASS_NAME);
     } else {
-      bannerClassList.remove('confidential-issue-scroll');
+      bannerClassList.remove(CONFIDENTIAL_ISSUE_SCROLL_CLASS_NAME);
     }
   };