summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLuke "Jared" Bennett <lbennett@gitlab.com>2017-05-24 08:47:25 +0000
committerLuke "Jared" Bennett <lbennett@gitlab.com>2017-05-24 08:47:25 +0000
commitae94fa3fb0ae114581c592d52f482990b52e8f18 (patch)
treef97213079c7f796155ee76e85cfbd0c8ca0f4e52
parent752277d34c1eda66d509a616c01d42d0d62f83d6 (diff)
downloadgitlab-ce-correct-compare_spec-transient.tar.gz
Add review comments to compare_spec.rbcorrect-compare_spec-transient
-rw-r--r--spec/features/projects/compare_spec.rb2
1 files changed, 2 insertions, 0 deletions
diff --git a/spec/features/projects/compare_spec.rb b/spec/features/projects/compare_spec.rb
index 3be9a59a15c..7a511eccb63 100644
--- a/spec/features/projects/compare_spec.rb
+++ b/spec/features/projects/compare_spec.rb
@@ -52,9 +52,11 @@ describe "Compare", js: true do
def select_using_dropdown(dropdown_type, selection)
dropdown = find(".js-compare-#{dropdown_type}-dropdown")
dropdown.find(".compare-dropdown-toggle").click
+ # find input before using to wait for the inputs visiblity
dropdown.find('.dropdown-menu')
dropdown.fill_in("Filter by Git revision", with: selection)
wait_for_ajax
+ # find before all to wait for the items visiblity
dropdown.find("a[data-ref=\"#{selection}\"]", match: :first)
dropdown.all("a[data-ref=\"#{selection}\"]").last.click
end