Don't fabricate a default project for the CI/CD testdd-qa-api-delegation-project-cicd-vars

Convert 'user adds a CI variable' to a :smoke test

Adjust support for API and UI fabrication

Signed-off-by: ddavison <ddavison@gitlab.com>

1 files changed, 12 insertions, 2 deletions

diff --git a/qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_ci_variable_spec.rb b/qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_ci_variable_spec.rb
index 33f342edb08..561a8895329 100644
--- a/qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_ci_variable_spec.rb
+++ b/qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_ci_variable_spec.rb
@@ -3,15 +3,25 @@
 module QA
   context 'Verify' do
     describe 'CI variable support' do
-      it 'user adds a CI variable' do
+      it 'user adds a CI variable', :smoke do
         Runtime::Browser.visit(:gitlab, Page::Main::Login)
-        Page::Main::Login.act { sign_in_using_credentials }
+        Page::Main::Login.perform(&:sign_in_using_credentials)
+
+        project = Resource::Project.fabricate! do |project|
+          project.name = 'project-with-ci-variables'
+          project.description = 'project with CI variables'
+        end
 
         Resource::CiVariable.fabricate! do |resource|
+          resource.project = project
           resource.key = 'VARIABLE_KEY'
           resource.value = 'some_CI_variable'
         end
 
+        project.visit!
+
+        Page::Project::Menu.perform(&:go_to_ci_cd_settings)
+
         Page::Project::Settings::CICD.perform do |settings|
           settings.expand_ci_variables do |page|
             expect(page).to have_field(with: 'VARIABLE_KEY')