summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDouwe Maan <douwe@selenight.nl>2018-11-06 17:18:03 +0100
committerDouwe Maan <douwe@selenight.nl>2018-11-06 17:18:03 +0100
commit4d23090877c2af3634a7f02802fb765d969bd38e (patch)
tree938d2614a08d370bac6701760bccbb5972ee030a
parent34e8d9726ddb63d1a9d05f6117d04da56aada5e3 (diff)
downloadgitlab-ce-dm-api-merge-requests-index-merged-at.tar.gz
Verify metrics don't introduce new N+1 issue in MR APIdm-api-merge-requests-index-merged-at
-rw-r--r--spec/support/shared_examples/requests/api/merge_requests_list.rb7
1 files changed, 6 insertions, 1 deletions
diff --git a/spec/support/shared_examples/requests/api/merge_requests_list.rb b/spec/support/shared_examples/requests/api/merge_requests_list.rb
index 1aed8ab0113..668a390b5d2 100644
--- a/spec/support/shared_examples/requests/api/merge_requests_list.rb
+++ b/spec/support/shared_examples/requests/api/merge_requests_list.rb
@@ -16,7 +16,12 @@ shared_examples 'merge requests list' do
create(:merge_request, state: 'closed', milestone: milestone1, author: user, assignee: user, source_project: project, target_project: project, title: 'Test', created_at: base_time)
- create(:merge_request, milestone: milestone1, author: user, assignee: user, source_project: project, target_project: project, title: 'Test', created_at: base_time)
+ merge_request = create(:merge_request, milestone: milestone1, author: user, assignee: user, source_project: project, target_project: project, title: 'Test', created_at: base_time)
+
+ merge_request.metrics.update!(merged_by: user,
+ latest_closed_by: user,
+ latest_closed_at: 1.hour.ago,
+ merged_at: 2.hours.ago)
expect do
get api(endpoint_path, user)