diff options
| author | Douwe Maan <douwe@selenight.nl> | 2019-04-16 18:44:39 +0200 |
|---|---|---|
| committer | Douwe Maan <douwe@selenight.nl> | 2019-04-16 18:44:39 +0200 |
| commit | 95dbc34e29876b9c6f2eaecfd45f9c4ac9824ca7 (patch) | |
| tree | 6d632306af3ef68a083e1e86c8b19d84e3219cfa | |
| parent | 0477cd00ddfbf7b05016c07cd5190fd4c2e9f635 (diff) | |
| download | gitlab-ce-dm-code-review-sla.tar.gz | |
Refer to guidelines on when to assign MRs close to the freezedm-code-review-sla
| -rw-r--r-- | doc/development/code_review.md | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index cfc5da33aa5..4e2213f7742 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -226,7 +226,10 @@ A turnaround time of two working days is usually acceptable, since engineers will typically have other things to work on while they're waiting for review, but don't hesitate to ask the author if it's unclear what time frame would be acceptable, how urgent the review is, or how significant the blockage. Authors -are also encouraged to provide this information up-front to reviewers. +are also encouraged to provide this information up-front to reviewers, but are +expected to be mindful of the [guidelines on when to ask for review on MRs that +are intended to go in before the feature freeze](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/PROCESS.md#between-the-1st-and-the-7th), +and realistic in their expectations if these were not followed. If you don't think you'll be able to review a merge request within a reasonable time frame, let the author know as soon as possible and try to help them find |