diff options
| author | Luke Duncalfe <lduncalfe@eml.cc> | 2019-08-15 16:56:04 +1200 |
|---|---|---|
| committer | Luke Duncalfe <lduncalfe@eml.cc> | 2019-08-19 09:04:43 +1200 |
| commit | c2c86e35149b20b4dc3af083cc16ac42d50b3e58 (patch) | |
| tree | bfea25ccf71382658ce2bbace4bf142f830960cf | |
| parent | 7c9fb3c61715acb7cb2bfcbad1a12a5ef66d9bbd (diff) | |
| download | gitlab-ce-doc-be_like_time.tar.gz | |
Add `be_like_time` matcher to Testing Styleguidedoc-be_like_time
| -rw-r--r-- | doc/development/testing_guide/best_practices.md | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md index 448d9fd01c4..c7e58f58c61 100644 --- a/doc/development/testing_guide/best_practices.md +++ b/doc/development/testing_guide/best_practices.md @@ -454,6 +454,19 @@ complexity of RSpec expectations.They should be placed under a certain type of specs only (e.g. features, requests etc.) but shouldn't be if they apply to multiple type of specs. +#### `be_like_time` + +Time returned from a database can differ in precision from time objects +in Ruby, so we need flexible tolerances when comparing in specs. We can +use `be_like_time` to compare that times are within one second of each +other. + +Example: + +```ruby +expect(metrics.merged_at).to be_like_time(time) +``` + #### `have_gitlab_http_status` Prefer `have_gitlab_http_status` over `have_http_status` because the former |