diff options
| author | Clement Ho <clemmakesapps@gmail.com> | 2018-02-12 20:05:23 +0000 |
|---|---|---|
| committer | Clement Ho <clemmakesapps@gmail.com> | 2018-02-12 20:05:23 +0000 |
| commit | b19e3650136b6659a755859ec2f5706889404853 (patch) | |
| tree | fe9bdd5d34c59ec92e748bd4ec5e11498eaf0d39 | |
| parent | 69efa4e1e89863f1ff426420effef057725ca385 (diff) | |
| download | gitlab-ce-docs-add-maintainer-guideline.tar.gz | |
Update code_review.mddocs-add-maintainer-guideline
| -rw-r--r-- | doc/development/code_review.md | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 7342fa6e192..b67270df9d9 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -71,10 +71,12 @@ request is up to one the project's maintainers, denoted on the ### Maintainers -- Avoid merging bad code even if that means delaying the release of a feature -- In the unlikely event that bad code needs to be merged, the associated MR - should have a note from a maintainer mentioning that the code has technical - debt and will be fixed by X date, otherwise the MR will be reverted. +- Do not merge code that will create technical debt even if that means + delaying the release of a feature. +- In the rare event that code with technical debt needs to be merged, the + associated MR should have a note from a maintainer mentioning that + the code has technical debt and will be fixed within 2 business days, + otherwise the MR will be reverted. ### Having your code reviewed |