summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDrew Blessing <drew@blessing.io>2019-08-12 19:57:42 +0000
committerDrew Blessing <drew@blessing.io>2019-08-12 19:57:42 +0000
commit190dc5f56bbc0190aa7a2992225eeff355b43a5e (patch)
treeaf743607ff89da48e68e533644b32bc3fd4f4ab8
parent71ec793214dd81701b5485aa10e20c9719cb0584 (diff)
downloadgitlab-ce-docs-custom-hook-error-msg-note.tar.gz
Add note to custom hooks error message documentationdocs-custom-hook-error-msg-note
From version 10.8 to 11.10, GitLab did not show custom hook error messages in the UI. This change adds a note to the docs including links to the MRs where the feature was removed and reintroduced.
-rw-r--r--doc/administration/custom_hooks.md7
1 files changed, 7 insertions, 0 deletions
diff --git a/doc/administration/custom_hooks.md b/doc/administration/custom_hooks.md
index 32462a95a1a..4a76ac78b9b 100644
--- a/doc/administration/custom_hooks.md
+++ b/doc/administration/custom_hooks.md
@@ -102,6 +102,13 @@ first script exiting with a non-zero value.
> [Introduced][5073] in GitLab 8.10.
+NOTE: **Note:**
+Error messages were not shown in the GitLab UI from version 10.8 to 11.10
+due to security concerns with the original implementation. See the discussion in
+[merge request 18646](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18646)
+for more information. The feature was reintroduced in 11.10 in
+[merge request 25625](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25625).
+
To have custom error messages appear in GitLab's UI when the commit is
declined or an error occurs during the Git hook, your script should: