diff options
| author | Clement Ho <ClemMakesApps@gmail.com> | 2018-03-06 15:47:42 -0600 |
|---|---|---|
| committer | Clement Ho <ClemMakesApps@gmail.com> | 2018-03-06 15:47:42 -0600 |
| commit | 60c6462c51ca5bee944534a667897692dd286a93 (patch) | |
| tree | 006ffaedf2cdc11b5bc1ba6184198e9e0153dca4 | |
| parent | 9947dd8005382c1c3fa03ea012b4a1861dc856e1 (diff) | |
| download | gitlab-ce-docs-fe-guide.tar.gz | |
Add avoid fake linksdocs-fe-guide
| -rw-r--r-- | doc/development/fe_guide/style/html.md | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/doc/development/fe_guide/style/html.md b/doc/development/fe_guide/style/html.md index 6ccd0405e23..bdd66da760b 100644 --- a/doc/development/fe_guide/style/html.md +++ b/doc/development/fe_guide/style/html.md @@ -27,4 +27,15 @@ This prevents a security vulnerability documented by [JitBit][JitBit] <a href="url" target="_blank" rel="noopener noreferrer"></a> ``` +<a name="fake-links"></a><a name="2.2"></a> +- [2.2](#fake-links) **Avoid using fake links** Buttons should be used if a link only invokes JavaScript click event handlers. + +``` +// bad +<a class="js-do-something" href="#"></a> + +// good +<button class="js-do-something" type="button"></button> +``` + [JitBit]: https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/ |